New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression | Revert PR #2281 SNIProxy code change #2395

Merged

DavoudEshtehari merged 2 commits into dotnet:main from JRahnama:revert2281

Mar 25, 2024

Merged

Regression | Revert PR #2281 SNIProxy code change #2395

Apply suggestions from code review

Azure Pipelines / CI-SqlClient (Win 11 Azure SQL net8.0,AnyCPU,true,1,netstandard2.1) succeeded Mar 8, 2024 in 45m 15s

Win 11 Azure SQL net8.0,AnyCPU,true,1,netstandard2.1 succeeded

3 errors / 1 warnings

Annotations

Check failure on line 0 in EXEC

azure-pipelines / CI-SqlClient (Win 11 Azure SQL net8.0,AnyCPU,true,1,netstandard2.1)

EXEC#L0

EXEC(0,0): Error Message:

Check failure on line 189 in build.proj

azure-pipelines / CI-SqlClient (Win 11 Azure SQL net8.0,AnyCPU,true,1,netstandard2.1)

build.proj#L189

build.proj(189,5): Error MSB3073: The command "dotnet test "src\Microsoft.Data.SqlClient\tests\ManualTests\Microsoft.Data.SqlClient.ManualTesting.Tests.csproj" -p:Configuration=Release -p:TargetnetcoreVersion=net8.0 --no-build -l "console;verbosity=normal" --collect "Code coverage" -p:TestSet=1 --results-directory TestResults -p:TestTargetOS=Windowsnetcoreapp --filter "category!=nonnetcoreapptests&category!=failing&category!=nonwindowstests" "--logger:trx;LogFilePrefix=Manual-Windowsnetcoreapp-1"" exited with code 1.

Check failure on line 3463 in Build log

azure-pipelines / CI-SqlClient (Win 11 Azure SQL net8.0,AnyCPU,true,1,netstandard2.1)

Build log #L3463

Process 'msbuild.exe' exited with code '1'.

View more details on Azure Pipelines