Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2.1] | Fix CodeQL and Rozlyn warnings (#2428) and (#2432) #2467

Merged
merged 1 commit into from
Apr 24, 2024

[5.2.1] | Fix CodeQL and Rozlyn warnings (#2428) and (#2432)

7dee5cd
Select commit
Loading
Failed to load commit list.
Merged

[5.2.1] | Fix CodeQL and Rozlyn warnings (#2428) and (#2432) #2467

[5.2.1] | Fix CodeQL and Rozlyn warnings (#2428) and (#2432)
7dee5cd
Select commit
Loading
Failed to load commit list.
Azure Pipelines / Release 5.2 cancelled Apr 18, 2024 in 8h 17m 34s

Build #10802 had test failures

59 errors / 11 warnings

Details

Tests

  • Failed: 5 (0.00%)
  • Passed: 286,919 (98.37%)
  • Other: 4,753 (1.63%)
  • Total: 291,677

Annotations

Check failure on line 1 in Microsoft.Data.SqlClient.ManualTesting.Tests.ConnectionExceptionTest.TestConnectionStateWithErrorClass20

See this annotation in the file changed.

@azure-pipelines azure-pipelines / Release 5.2

Microsoft.Data.SqlClient.ManualTesting.Tests.ConnectionExceptionTest.TestConnectionStateWithErrorClass20 

Assert.Equal() Failure: Values differ
Expected: 11
Actual:   20
Raw output 
   at Microsoft.Data.SqlClient.ManualTesting.Tests.ConnectionExceptionTest.TestConnectionStateWithErrorClass20() in /_/src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ExceptionTest/ConnectionExceptionTest.cs:line 43

Check failure on line 1 in Microsoft.Data.SqlClient.Tests.SqlConnectionBasicTests.ConnectionTimeoutTestAsync(timeout: 5)

See this annotation in the file changed.

@azure-pipelines azure-pipelines / Release 5.2

Microsoft.Data.SqlClient.Tests.SqlConnectionBasicTests.ConnectionTimeoutTestAsync(timeout: 5) 

The actual timeout 9.0990582 is expected to be less than 5 plus 3 seconds additional threshold.
Microsoft.Data.SqlClient.SqlException (0x80131904): A network-related or instance-specific error occurred while establishing a connection to SQL Server. The server was not found or was not accessible. Verify that the instance name is correct and that SQL Server is configured to allow remote connections. (provider: TCP Provider, error: 0 - The wait operation timed out.)
 ---> System.ComponentModel.Win32Exception (258): The wait operation timed out.
   at Microsoft.Data.SqlClient.SqlInternalConnection.OnError(SqlException exception, Boolean breakConnection, Action`1 wrapCloseInAction) in /_/src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlInternalConnection.cs:line 779
   at Microsoft.Data.SqlClient.TdsParser.ThrowExceptionAndWarning(TdsParserStateObject stateObj, SqlCommand command, Boolean callerHasConnectionLock, Boolean asyncClose) in /_/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParser.cs:line 1447
   at Microsoft.Data.SqlClient.TdsParser.Connect(ServerInfo serverInfo, SqlInternalConnectionTds connHandler, TimeoutTimer timeout, SqlConnectionString connectionOptions, Boolean withFailover) in /_/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParser.cs:line 605
   at Microsoft.Data.SqlClient.SqlInternalConnectionTds.AttemptOneLogin(ServerInfo serverInfo, String newPassword, SecureString newSecurePassword, TimeoutTimer timeout, Boolean withFailover) in /_/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlInternalConnectionTds.cs:line 1938
   at Microsoft.Data.SqlClient.SqlInternalConnectionTds.LoginNoFailover(ServerInfo serverInfo, String newPassword, SecureString newSecurePassword, Boolean redirectedUserInstance, SqlConnectionString connectionOptions, SqlCredential credential, TimeoutTimer timeout) in /_/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlInternalConnectionTds.cs:line 1552
   at Microsoft.Data.SqlClient.SqlInternalConnectionTds.OpenLoginEnlist(TimeoutTimer timeout, SqlConnectionString connectionOptions, SqlCredential credential, String newPassword, SecureString newSecurePassword, Boolean redirectedUserInstance) in /_/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlInternalConnectionTds.cs:line 1450
   at Microsoft.Data.SqlClient.SqlInternalConnectionTds..ctor(DbConnectionPoolIdentity identity, SqlConnectionString connectionOptions, SqlCredential credential, Object providerInfo, String newPassword, SecureString newSecurePassword, Boolean redirectedUserInstance, SqlConnectionString userConnectionOptions, SessionData reconnectSessionData, Boolean applyTransientFaultHandling, String accessToken, DbConnectionPool pool, Func`3 accessTokenCallback) in /_/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlInternalConnectionTds.cs:line 520
   at Microsoft.Data.SqlClient.SqlConnectionFactory.CreateConnection(DbConnectionOptions options, DbConnectionPoolKey poolKey, Object poolGroupProviderInfo, DbConnectionPool pool, DbConnection owningConnection, DbConnectionOptions userOptions) in /_/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlConnectionFactory.cs:line 136
   at Microsoft.Data.ProviderBase.DbConnectionFactory.CreatePooledConnection(DbConnectionPool pool, DbConnection owningObject, DbConnectionOptions options, DbConnectionPoolKey poolKey, DbConnectionOptions userOptions) in /_/src/Microsoft.Data.SqlClient/netcore/src/Common/src/Microsoft/Data/ProviderBase/DbConnectionFactory.cs:line 123
   at Microsoft.Data.ProviderBase.DbConnectionPool.CreateObject(DbConnection owningObject, DbConnectionOptions userOptions, DbConnectionInternal oldConnection) in /_/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/ProviderBase/DbConnectionPool.cs:line 731
   at Microsoft.Data.ProviderBase.DbConnectionPool.UserCreateRequest(DbConnection owningObject, DbConnectionOpt
Raw output 
   at Microsoft.Data.SqlClient.Tests.SqlConnectionBasicTests.ConnectionTimeoutTestAsync(Int32 timeout) in /_/src/Microsoft.Data.SqlClient/tests/FunctionalTests/SqlConnectionBasicTests.cs:line 373
   at System.Threading.Tasks.Task.<>c.<ThrowAsync>b__128_0(Object state)

Check failure on line 1 in Microsoft.Data.SqlClient.ManualTesting.Tests.EventCounterTest.EventCounter_ReclaimedConnectionsCounter_Functional

See this annotation in the file changed.

@azure-pipelines azure-pipelines / Release 5.2

Microsoft.Data.SqlClient.ManualTesting.Tests.EventCounterTest.EventCounter_ReclaimedConnectionsCounter_Functional 

Assert.Equal() Failure: Values differ
Expected: 3
Actual:   2
Raw output 
   at Microsoft.Data.SqlClient.ManualTesting.Tests.EventCounterTest.EventCounter_ReclaimedConnectionsCounter_Functional() in /_/src/Microsoft.Data.SqlClient/tests/ManualTests/TracingTests/EventCounterTest.cs:line 171
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

Check failure on line 1 in Microsoft.Data.SqlClient.ManualTesting.Tests.ConnectionExceptionTest.TestConnectionStateWithErrorClass20

See this annotation in the file changed.

@azure-pipelines azure-pipelines / Release 5.2

Microsoft.Data.SqlClient.ManualTesting.Tests.ConnectionExceptionTest.TestConnectionStateWithErrorClass20 

Assert.Equal() Failure: Values differ
Expected: 11
Actual:   20
Raw output 
   at Microsoft.Data.SqlClient.ManualTesting.Tests.ConnectionExceptionTest.TestConnectionStateWithErrorClass20() in /_/src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ExceptionTest/ConnectionExceptionTest.cs:line 43
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
View more details on Azure Pipelines