Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline conditional compilation symbols #2486

Merged
merged 3 commits into from
May 14, 2024

Conversation

ErikEJ
Copy link
Contributor

@ErikEJ ErikEJ commented May 7, 2024

fixes #2484

@ErikEJ
Copy link
Contributor Author

ErikEJ commented May 7, 2024

@DavoudEshtehari @JRahnama FYI

@DavoudEshtehari DavoudEshtehari added this to the 6.0-preview1 milestone May 7, 2024
@DavoudEshtehari DavoudEshtehari added the ➕ Code Health Changes related to source code improvements label May 7, 2024
Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 72.72%. Comparing base (48ab625) to head (588bc2b).
Report is 3 commits behind head on main.

❗ Current head 588bc2b differs from pull request most recent head 5f70372. Consider uploading reports for the commit 5f70372 to get more accurate results

Files Patch % Lines
...netcore/src/Microsoft/Data/SqlClient/SqlCommand.cs 50.00% 1 Missing ⚠️
...c/Microsoft/Data/Interop/SNINativeMethodWrapper.cs 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2486      +/-   ##
==========================================
+ Coverage   72.68%   72.72%   +0.03%     
==========================================
  Files         313      313              
  Lines       61727    61734       +7     
==========================================
+ Hits        44867    44896      +29     
+ Misses      16860    16838      -22     
Flag Coverage Δ
addons 92.88% <ø> (ø)
netcore 77.06% <88.88%> (+0.09%) ⬆️
netfx 70.39% <90.90%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DavoudEshtehari DavoudEshtehari merged commit cc6ea21 into dotnet:main May 14, 2024
148 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
➕ Code Health Changes related to source code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal to streamline use of conditional compilation symbols
5 participants