Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2.1] | Fix SqlConnection.FireInfoMessageEventOnUserErrors when set to true throws an exception (#2399) #2505

Merged

Conversation

DavoudEshtehari
Copy link
Contributor

Ports #2399

@DavoudEshtehari DavoudEshtehari added the 🐛 Bug! Issues that are bugs in the drivers we maintain. label May 16, 2024
Copy link
Contributor

@arellegue arellegue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.63%. Comparing base (82be9a6) to head (036bcb0).
Report is 2 commits behind head on release/5.2.

Current head 036bcb0 differs from pull request most recent head c2bca36

Please upload reports for the commit c2bca36 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff              @@
##           release/5.2    #2505   +/-   ##
============================================
  Coverage        72.63%   72.63%           
============================================
  Files              310      310           
  Lines            61875    61875           
============================================
+ Hits             44942    44943    +1     
+ Misses           16933    16932    -1     
Flag Coverage Δ
addons 92.88% <ø> (ø)
netcore 76.83% <100.00%> (-0.03%) ⬇️
netfx 70.18% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DavoudEshtehari DavoudEshtehari merged commit 82de540 into dotnet:release/5.2 May 17, 2024
148 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug! Issues that are bugs in the drivers we maintain.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants