Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2.1] | Revert the fix transient fault handling issue with OpenAsync (#1983) #2507

Merged

Conversation

DavoudEshtehari
Copy link
Contributor

@DavoudEshtehari DavoudEshtehari commented May 16, 2024

Reverts #1983 due to this comment.

…ing issue with OpenAsync (dotnet#1983)"

This reverts commit 80d1f47.

# Conflicts:
#	src/Microsoft.Data.SqlClient/tests/FunctionalTests/SqlConnectionBasicTests.cs
Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.64%. Comparing base (82be9a6) to head (4bb26b0).
Report is 1 commits behind head on release/5.2.

Current head 4bb26b0 differs from pull request most recent head 908091f

Please upload reports for the commit 908091f to get more accurate results.

Additional details and impacted files
@@               Coverage Diff               @@
##           release/5.2    #2507      +/-   ##
===============================================
+ Coverage        72.63%   72.64%   +0.01%     
===============================================
  Files              310      310              
  Lines            61875    61875              
===============================================
+ Hits             44942    44949       +7     
+ Misses           16933    16926       -7     
Flag Coverage Δ
addons 92.88% <ø> (ø)
netcore 76.88% <100.00%> (+0.02%) ⬆️
netfx 70.15% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DavoudEshtehari DavoudEshtehari merged commit 2391025 into dotnet:release/5.2 May 17, 2024
148 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants