Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2.1] | Clone of SqlConnection should include AccessTokenCallback #2527

Merged

Conversation

David-Engel
Copy link
Contributor

@David-Engel David-Engel commented May 22, 2024

Backport of #2525 to 5.2.1.

Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.61%. Comparing base (82de540) to head (9d6ccf1).
Report is 1 commits behind head on release/5.2.

Current head 9d6ccf1 differs from pull request most recent head f0707ef

Please upload reports for the commit f0707ef to get more accurate results.

Additional details and impacted files
@@               Coverage Diff               @@
##           release/5.2    #2527      +/-   ##
===============================================
- Coverage        72.65%   72.61%   -0.04%     
===============================================
  Files              310      310              
  Lines            61876    61879       +3     
===============================================
- Hits             44955    44935      -20     
- Misses           16921    16944      +23     
Flag Coverage Δ
addons 92.88% <ø> (ø)
netcore 76.80% <100.00%> (-0.11%) ⬇️
netfx 70.18% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ErikEJ
Copy link
Contributor

ErikEJ commented May 23, 2024

LGTM - will this make 5.2.1 ?

@JRahnama
Copy link
Member

LGTM - will this make 5.2.1 ?

yes

@David-Engel David-Engel changed the title [5.2.?] | Clone of SqlConnection should include AccessTokenCallback [5.2.1] | Clone of SqlConnection should include AccessTokenCallback May 23, 2024
@DavoudEshtehari DavoudEshtehari added the 🐛 Bug! Something isn't right ! label May 23, 2024
@DavoudEshtehari DavoudEshtehari merged commit f059577 into dotnet:release/5.2 May 23, 2024
148 checks passed
@David-Engel David-Engel deleted the cloneTokenCallback5.2 branch June 3, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug! Something isn't right !
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants