Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advance column index to avoid double clean. #2825

Merged
merged 7 commits into from
Sep 9, 2024
Merged

Advance column index to avoid double clean. #2825

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
41bbd86
Advance column index to avoid double clean.
mdaigle Aug 29, 2024
a9af46a
Update comment. Remove unnecessary check.
mdaigle Aug 29, 2024
c4ba1e2
Add copy test structure as starting point. Add new test table.
mdaigle Sep 4, 2024
8fd8ad1
Implement tests. Add null safety to cleanup code. Only compile for .n…
mdaigle Sep 6, 2024
a96dbd4
Add comment
mdaigle Sep 6, 2024
780c938
Add test explanation and fix max pool size to 1.
mdaigle Sep 6, 2024
3ed1412
Fix item group for test table class.
mdaigle Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6395,6 +6395,7 @@ internal TdsOperationStatus TryReadSqlValue(SqlBuffer value, SqlMetaDataPriv md,
{
// Drain the pending data now if setting the HasPendingData to false.
// SqlDataReader.TryCloseInternal can not drain if HasPendingData = false.
stateObj._readerState._nextColumnDataToRead++;
DrainData(stateObj);
}
stateObj.HasPendingData = false;
Expand Down
Loading