Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove non-working BID code #283

Merged
merged 2 commits into from
Oct 24, 2019
Merged

Remove non-working BID code #283

merged 2 commits into from
Oct 24, 2019

Conversation

David-Engel
Copy link
Contributor

Addresses #260

yukiwongky
yukiwongky suggested changes Oct 23, 2019
View reviewed changes
Copy link
Contributor

@yukiwongky yukiwongky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 minor comments.

@David-Engel David-Engel merged commit da1fe26 into dotnet:master Oct 24, 2019
@David-Engel David-Engel deleted the 260 branch October 24, 2019 19:54
@David-Engel David-Engel added this to the 1.1.0 milestone Oct 24, 2019
@David-Engel David-Engel modified the milestones: 1.1.0, 1.1.0-preview2 Nov 4, 2019
yukiwongky pushed a commit to yukiwongky/SqlClient that referenced this pull request Nov 5, 2019
@David-Engel
Remove non-working BID code (dotnet#283)
8007304
yukiwongky pushed a commit to yukiwongky/SqlClient that referenced this pull request Nov 5, 2019
@David-Engel
Remove non-working BID code (dotnet#283)
2b807a0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yukiwongky yukiwongky yukiwongky approved these changes

@karinazhou karinazhou Awaiting requested review from karinazhou

@JRahnama JRahnama Awaiting requested review from JRahnama

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.0-preview2
Development

Successfully merging this pull request may close these issues.
2 participants
@David-Engel @yukiwongky