Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Sure Common Project Doesn't Built #2907

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

benrr101
Copy link
Contributor

@benrr101 benrr101 commented Oct 9, 2024

Description: I'm not entirely sure what was causing the project to be included in solution-based builds (ie, VS, etc), but I've verified that it is not being included any longer. Building the solution in VS works as expected without any errors from the common project.

Testing: I've verified the solution builds correctly in VS 2022 and Rider. It never built in CI pipelines, and there aren't any changes to make it build in pipelines.

Please verify it works on your system. It may be necessary to run a git clean -xfd on your solution root folder if you continue to encounter build issues.

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.86%. Comparing base (ca9272d) to head (d012138).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2907      +/-   ##
==========================================
- Coverage   72.22%   71.86%   -0.36%     
==========================================
  Files         297      294       -3     
  Lines       61091    60253     -838     
==========================================
- Hits        44120    43299     -821     
+ Misses      16971    16954      -17     
Flag Coverage Δ
addons 92.90% <ø> (ø)
netcore 75.81% <ø> (-0.15%) ⬇️
netfx 70.36% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@David-Engel David-Engel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be necessary to run a git clean -xfd on your solution root folder if you continue to encounter build issues.

Even though a build "succeeded", I did have to run git clean to get rid of all the errors reported in VS. Even a rebuild (clean+build) in VS didn't get rid of them.

@benrr101
Copy link
Contributor Author

@David-Engel Yeah, a "clean" doesn't really do much of anything. It leaves behind loads of files and the best way to properly clean up a solution is to git -xfd. But thanks for confirming that worked.

Copy link
Member

@cheenamalhotra cheenamalhotra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked for me too! Thanks for addressing this!

@cheenamalhotra cheenamalhotra linked an issue Oct 11, 2024 that may be closed by this pull request
@benrr101 benrr101 merged commit e4a6e7c into dotnet:main Oct 11, 2024
130 checks passed
@benrr101 benrr101 deleted the really-dont-build-common-proj branch October 11, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MDS solution build errors in 'main' branch
3 participants