-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Sure Common Project Doesn't Built #2907
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2907 +/- ##
==========================================
- Coverage 72.22% 71.86% -0.36%
==========================================
Files 297 294 -3
Lines 61091 60253 -838
==========================================
- Hits 44120 43299 -821
+ Misses 16971 16954 -17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may be necessary to run a
git clean -xfd
on your solution root folder if you continue to encounter build issues.
Even though a build "succeeded", I did have to run git clean to get rid of all the errors reported in VS. Even a rebuild (clean+build) in VS didn't get rid of them.
@David-Engel Yeah, a "clean" doesn't really do much of anything. It leaves behind loads of files and the best way to properly clean up a solution is to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked for me too! Thanks for addressing this!
Description: I'm not entirely sure what was causing the project to be included in solution-based builds (ie, VS, etc), but I've verified that it is not being included any longer. Building the solution in VS works as expected without any errors from the common project.
Testing: I've verified the solution builds correctly in VS 2022 and Rider. It never built in CI pipelines, and there aren't any changes to make it build in pipelines.
Please verify it works on your system. It may be necessary to run a
git clean -xfd
on your solution root folder if you continue to encounter build issues.