Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge | Pull in the rest of the interop files #2933

Merged
merged 11 commits into from
Nov 1, 2024

Conversation

benrr101
Copy link
Contributor

Description: This PR is pretty straightforward, it brings in the rest of the files used for "interop". This is the first stage of a series of PRs that I've been working on that migrate the interop class to an interop namespace. This is a prerequisite for a prerequisite for merging LocalDBAPI. It is not strictly required, but it will make my life easier for merging the LocalDBAPI, and ideally it is work that should be done eventually anyhow.

Keep in mind if #2927 goes through, much of this code can be deleted since it is no longer needed in net8 or above.

This PR only moves the files, it does not make any code changes.

Testing: Projects still build, so there is no issue.

@benrr101
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@edwardneal
Copy link
Contributor

This looks good to me.

On a more general note, it looks like we're moving away from the various NativeMethods, SafeNativeMethods and UnsafeNativeMethods classes? If so my PR #2828 removes the currently-unused PInvokes from these code files, so there's no need to bother migrating those. There are quite a few other PInvokes in those files which are only used within the SQLDebugging class (and associated debugging infrastructure) though. I'd suggest ignoring those too - SQLDebugging is only used when debugging a client application connected to a local SQL 2000 instance, and when this is no longer permitted I'm planning to submit a PR which will eliminate that functionality and remove these PInvokes anyway.

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@fc0acc0). Learn more about missing BASE report.
Report is 14 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2933   +/-   ##
=======================================
  Coverage        ?   72.28%           
=======================================
  Files           ?      288           
  Lines           ?    59663           
  Branches        ?        0           
=======================================
  Hits            ?    43128           
  Misses          ?    16535           
  Partials        ?        0           
Flag Coverage Δ
addons 92.58% <ø> (?)
netcore 75.37% <ø> (?)
netfx 70.68% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benrr101
Copy link
Contributor Author

benrr101 commented Nov 1, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@benrr101 benrr101 merged commit 984d544 into dotnet:main Nov 1, 2024
76 checks passed
@benrr101 benrr101 deleted the interop/therestofthefiles branch November 1, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants