Merge | Add IDBColumnSchemaGenerator interface to netfx SqlDataReader

[MichelZ]

Bring IDBColumnSchemaGenerator to netfx for later code base merging

I made sure to enable the respective test for netfx

Part of #2965

[MichelZ]

/azp run

[azure-pipelines]

Commenter does not have sufficient privileges for PR 2967 in repo dotnet/SqlClient

[MichelZ]

@edwardneal Would you mind running the pipeline for me on this one? :)

[edwardneal]

Thanks for this MichelZ. The changes look good to me; would you mind feeding the extra package reference through to the nuspec file and the .NET Framework reference csproj please?

I don't have access to the pipelines, but hopefully the SqlClient team will be able to look at it in a few days. Something's definitely odd there - your PRs didn't run the CI builds, and my commit ran the CI build but encountered a lot more timeouts than normal in the tests.

[MichelZ]

Will do. I'm not a contributor, that's probably why the pipelines don't run for me (yet)
(Can you try to just do an /azp run and see what happens?)

[edwardneal]

/azp run

[azure-pipelines]

Commenter does not have sufficient privileges for PR 2967 in repo dotnet/SqlClient

[MichelZ]

Thanks for trying :)

[ErikEJ]

/azp run

[azure-pipelines]

Commenter does not have sufficient privileges for PR 2967 in repo dotnet/SqlClient

[benrr101]

@ErikEJ @edwardneal @MichelZ We have changed security rules recently such that only contributors can kick off pipeline runs. This is due to the potential for contributors to run code in PRs that could be hazardous to our build agents or cause a DoS.

[benrr101]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[MichelZ]

This package needs to be added to the sqlclientdriver nuget feed for this build to succeed:
System.Data.Common: 4.3.0

[benrr101]

@MichelZ I might've mentioned it before but yep, we've got security on the internal nuget feed such that only contributors can pull upstream packages from the feed. I've gone ahead and added System.Data.Common 4.3.0 to the feed, so it should be good to go.

[benrr101]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[benrr101]

I'd need to see @cheenamalhotra 's opinion regarding the System.Data.Common inclusion before I explicitly approve.

[cheenamalhotra]

LGTM overall, please resolve conflicts when possible.

[MichelZ]

Done. I'd need another /azp run I guess :)

[David-Engel]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.58%. Comparing base (7d93424) to head (e511463).
Report is 1 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #2967       +/-   ##
===========================================
+ Coverage   72.76%   92.58%   +19.81%     
===========================================
  Files         283        6      -277     
  Lines       58968      310    -58658     
===========================================
- Hits        42908      287    -42621     
+ Misses      16060       23    -16037     

Flag	Coverage Δ
addons	92.58% <ø> (ø)
netcore	?
netfx	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[MichelZ]

I'm currently unsure what causes this issue....

"G:\MIZE\DEV\GitHub\SqlClient\build.proj" (BuildTestsNetFx target) (1) ->
"G:\MIZE\DEV\GitHub\SqlClient\src\Microsoft.Data.SqlClient\tests\ManualTests\Microsoft.Data.SqlClient.ManualTesting.Tests.csproj" (default target) (11:11) ->
"G:\MIZE\DEV\GitHub\SqlClient\src\Microsoft.Data.SqlClient\tests\ManualTests\Microsoft.Data.SqlClient.ManualTesting.Tests.csproj" (Build target) (11:12) ->
(CoreCompile target) ->
  G:\MIZE\DEV\GitHub\SqlClient\src\Microsoft.Data.SqlClient\tests\ManualTests\SQL\UdtTest\SqlServerTypesTest.cs(264,86): error CS1061: 'SqlDataReader' does not contain a definition for 'GetColumnSchema' and no accessib
le extension method 'GetColumnSchema' accepting a first argument of type 'SqlDataReader' could be found (are you missing a using directive or an assembly reference?) [G:\MIZE\DEV\GitHub\SqlClient\src\Microsoft.Data.Sql
Client\tests\ManualTests\Microsoft.Data.SqlClient.ManualTesting.Tests.csproj::TargetFramework=net462]

The method is clearly available

[cheenamalhotra]

@MichelZ could you please resolve conflicts? Thx.

[MichelZ]

@cheenamalhotra Done! :)