-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge | Align Task usage / ArrayPool / IsColumnEncryptionSupported netcore/netfx #2982
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2982 +/- ##
==========================================
- Coverage 72.50% 72.46% -0.04%
==========================================
Files 288 288
Lines 59529 59507 -22
==========================================
- Hits 43159 43122 -37
- Misses 16370 16385 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, I think this is a decent change. I'm hesitant to start touching things in the TdsParser, but these changes seem to be pretty constrained. Only a few comments. Not sure about the feasibility of using stackalloc instead of array pool in the last commit.
Part of #2953
Aligning Task return, bringing over ArrayPool usage and aligning IsColumnEncryptionSupported changes between netcore and netfx