Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge | Align Task usage / ArrayPool / IsColumnEncryptionSupported netcore/netfx #2982

Merged
merged 14 commits into from
Nov 26, 2024

Conversation

MichelZ
Copy link
Contributor

@MichelZ MichelZ commented Nov 6, 2024

Part of #2953

Aligning Task return, bringing over ArrayPool usage and aligning IsColumnEncryptionSupported changes between netcore and netfx

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 75.67568% with 18 lines in your changes missing coverage. Please review.

Project coverage is 72.46%. Comparing base (4bc9ee6) to head (43a4fd6).
Report is 38 commits behind head on main.

Files with missing lines Patch % Lines
...nt/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs 78.26% 15 Missing ⚠️
.../netcore/src/Microsoft/Data/SqlClient/TdsParser.cs 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2982      +/-   ##
==========================================
- Coverage   72.50%   72.46%   -0.04%     
==========================================
  Files         288      288              
  Lines       59529    59507      -22     
==========================================
- Hits        43159    43122      -37     
- Misses      16370    16385      +15     
Flag Coverage Δ
addons 92.58% <ø> (ø)
netcore 75.39% <40.00%> (-0.05%) ⬇️
netfx 70.90% <78.26%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@benrr101 benrr101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, I think this is a decent change. I'm hesitant to start touching things in the TdsParser, but these changes seem to be pretty constrained. Only a few comments. Not sure about the feasibility of using stackalloc instead of array pool in the last commit.

@MichelZ MichelZ requested a review from benrr101 November 19, 2024 07:50
@MichelZ MichelZ changed the title Align Task usage / ArrayPool / IsColumnEncryptionSupported netcore/netfx Merge | Align Task usage / ArrayPool / IsColumnEncryptionSupported netcore/netfx Nov 24, 2024
@mdaigle mdaigle added the Common Project 🚮 Things that relate to the common project project label Nov 25, 2024
@benrr101 benrr101 merged commit d4d5eba into dotnet:main Nov 26, 2024
76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Common Project 🚮 Things that relate to the common project project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants