-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add package vulnerability information #3024
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3024 +/- ##
==========================================
+ Coverage 72.64% 72.73% +0.08%
==========================================
Files 285 285
Lines 59160 59160
==========================================
+ Hits 42979 43028 +49
+ Misses 16181 16132 -49
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Also related to #2568 |
cheenamalhotra
approved these changes
Nov 21, 2024
cheenamalhotra
requested review from
benrr101,
mdaigle,
apoorvdeshmukh and
David-Engel
November 21, 2024 18:00
mdaigle
approved these changes
Nov 25, 2024
mdaigle
added
the
➕ Code Health
Issues/PRs that are targeted to source code quality improvements.
label
Nov 25, 2024
cheenamalhotra
added a commit
that referenced
this pull request
Jan 24, 2025
cheenamalhotra
added a commit
that referenced
this pull request
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AI Blurp
This pull request includes changes to the NuGet configuration and build properties to improve package source auditing and manage warnings more effectively. The most important changes are as follows:
NuGet Configuration Updates:
NuGet.config
: Added anauditSources
section to specify sources for auditing, includingnuget.org
as an audit source.Build Properties Enhancements:
src/Directory.Build.props
: Introduced aWarningsNotAsErrors
property to exclude specific warnings from being treated as errors.src/Directory.Build.props
: Added aNuGetAuditMode
property to enable auditing for all package sources.Description
Adding new functionality for .NET 9 / VS 17.12 / NuGet 6.12 with Audit Sources.
Also adding that the vulnerabilities (currently) are not treated as errors, but this can of course be enabled in the future
The idea is that package vulnerabilities get visibility at least on a warning level everywhere.
I'm sure I don't have to remind anyone of this, but I still do 😁 :
https://blogs.microsoft.com/blog/2024/05/03/prioritizing-security-above-all-else/