-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow large UDT buffers for netfx #456
Conversation
It'll do the job. I'd prefer the new exception type and message from the other PR to come over as well but it should almost never be thrown so it isn't a huge probem. |
@Wraith2 What should be done to have this reviewed and merged? It seems I don't have rights to request a review. |
You just wait i'm afraid. |
In all fairness to @alsicbv as a contributor I can only make suggestions and it wasn't clear that it was my suggestion that was being waited for. I think both he and I assumed that the PR was waiting for review from the owner side. |
Oops! |
Ok, it wasn't clear to me... Thanks for clarifying, I'm not working tomorrow so I'll do it on Friday! |
I've made all changes from the original PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor suggestion
fixes #329 for netfx
The fix in #340 was only for netcore. Issue #329 still exists when using EF core on Net Framework.
/cc @ajcvickers @aprognimak @Wraith2