Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NetFX] DEV | Drop support for Net46 and add support for Net461 #899

Merged
merged 9 commits into from
Mar 1, 2021
Merged

[NetFX] DEV | Drop support for Net46 and add support for Net461 #899

merged 9 commits into from
Mar 1, 2021

Conversation

JRahnama
Copy link
Contributor

@JRahnama JRahnama commented Feb 3, 2021 •
edited
Loading

This PR is the first part of the task to drop support for net46 and add support for net461.
This PR is merely making SDK's features available for other developments in progress for now.

Another PR will be made to address probable upgrades/enhancements in the driver accordingly if there is any.

Net461 Release notes

@Wraith2
Copy link
Contributor

Wraith2 commented Feb 3, 2021

Just out of interest what scenarios does this unblock?

@JRahnama
Copy link
Contributor Author

JRahnama commented Feb 3, 2021

Just out of interest what scenarios does this unblock?

Although this is a minor version upgrade, there are several improvements in Net461 such bug fixes and a better performance in some areas. This may have some improvements to our test labs as well regarding the netfx failures. Plus it will prevent a huge jump in future when a major version change comes up. I am personally waiting for 4.7.1 which has so many features available such RuntimeInformation

@cheenamalhotra
Copy link
Member

Just out of interest what scenarios does this unblock?

Using Azure.Identity as a dependency for AD authentication :)

@JRahnama JRahnama changed the title WIP | Drop support for Net46 and add support for Net461 FIX | Drop support for Net46 and add support for Net461 Feb 4, 2021
@JRahnama JRahnama changed the title FIX | Drop support for Net46 and add support for Net461 [NetFX] DEV | Drop support for Net46 and add support for Net461 Feb 4, 2021
cheenamalhotra
cheenamalhotra reviewed Feb 17, 2021
View reviewed changes
Copy link
Member

@cheenamalhotra cheenamalhotra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes needed:

  • Readme.md: Update "Supportability" section.
  • BuildGuide.md: Line 72 (Default .NET Framework version is 4.6.)

@cheenamalhotra cheenamalhotra added this to the 3.0.0-preview1 milestone Feb 19, 2021
@cheenamalhotra cheenamalhotra added the 🔨 Breaking Change Issues/PRs that are related with breaking API changes in the driver. label Feb 19, 2021
@cheenamalhotra
Copy link
Member

@JRahnama
Please update pipelines to build for net461 and rerun them here - as we need that change eventually.

cheenamalhotra
cheenamalhotra approved these changes Feb 25, 2021
View reviewed changes
Copy link
Member

@cheenamalhotra cheenamalhotra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After all Pipelines pass, this can be merged.

Merge branch 'master' of https://github.com/dotnet/SqlClient into net461
595ed13 
# Conflicts:
#	src/Microsoft.Data.SqlClient/tests/FunctionalTests/AlwaysEncryptedTests/ExceptionsCertStore.cs
@cheenamalhotra
Copy link
Member

/azp run CI-BuildNPack

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@cheenamalhotra cheenamalhotra merged commit bcdeff3 into dotnet:master Mar 1, 2021
@JRahnama JRahnama deleted the net461 branch July 6, 2021 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karinazhou karinazhou karinazhou approved these changes

@cheenamalhotra cheenamalhotra cheenamalhotra approved these changes

@johnnypham johnnypham Awaiting requested review from johnnypham

@DavoudEshtehari DavoudEshtehari Awaiting requested review from DavoudEshtehari

Assignees
No one assigned
Labels
🔨 Breaking Change Issues/PRs that are related with breaking API changes in the driver.
Projects
None yet
Milestone
3.0.0-preview1
Development

Successfully merging this pull request may close these issues.
4 participants
@JRahnama @Wraith2 @cheenamalhotra @karinazhou