Manual updates 20241112 androidx.media3.exoplayer fixes

[moljac]

Fixes for

#1061

#985

#954

[moljac]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[moljac]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

Copilot reviewed 2 out of 5 changed files in this pull request and generated no comments.

Files not reviewed (3)

• source/androidx.media3/media3-exoplayer-hls/Transforms/Metadata.xml: Language not supported
• source/androidx.media3/media3-exoplayer-rtsp/Transforms/Metadata.xml: Language not supported
• source/androidx.media3/media3-exoplayer/Transforms/Metadata.xml: Language not supported

[moljac]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[moljac]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[moljac]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[jpobst]

My main concern here is the extensive API breakage these fixes require, particularly:

#### Type Changed: AndroidX.Media3.ExoPlayer.Source.ExternallyLoadedMediaSource.Factory.Factory

Removed interface:
IMediaSourceFactory

Added interface:
IMediaSourceMediaSourceIFactory

Xamarin.AndroidX.Media3.ExoPlayer.dll.diff.md

It appears related to nested interfaces, I wonder if we would be better off opting in to allowing nested interfaces like:

https://github.com/dotnet/android-libraries/pull/956/files#diff-9da24614831c308827a1ae533ffea392c97638c261dd42bd0f5226baa136d16eR2-R6

However this may just create different API breakages.

Given that MAUI community toolkit is already using our existing Media3 packages, perhaps we should ask @ne0rrmatrix to weigh in.

Additionally some other people who appear to already be using these packages from the filed issues:
@ArchangelWTF, @wilsonvargas, @datvm

[moljac]

My main concern here is the extensive API breakage these fixes require, particularly:

#### Type Changed: AndroidX.Media3.ExoPlayer.Source.ExternallyLoadedMediaSource.Factory.Factory

Removed interface:
IMediaSourceFactory

Added interface:
IMediaSourceMediaSourceIFactory

The problem was with 2 interfaces MediaSourceFactory and MediaSource.Factory and they inherit from each other. The error was that there was cyclic inheritance/dependency, but it was not, because there are 2 interfaces.
Generator did remove . in 2nd interface and that caused cyclic inheritance and error.

Thus managed side we have IMediaSourceFactory (from java MediaSourceFactory) and IMediaSourceFactory (from java MediaSource.Factory).

Renaming one of them:

    <attr
        path="/api/package[@name='androidx.media3.exoplayer.source']/interface[@name='MediaSource.Factory']"
        name="managedName"
        >
        IMediaSourceIFactory
    </attr>
    <attr
        path="/api/package[@name='androidx.media3.exoplayer.source']/interface[@name='MediaSourceFactory']"
        name="managedName"
        >
        IMediaSourceFactory
    </attr>

Maybe I can try different renaming (to preserve IMediaSourceFactory), but I think there will be some other API breakage.

Xamarin.AndroidX.Media3.ExoPlayer.dll.diff.md

It appears related to nested interfaces, I wonder if we would be better off opting in to allowing nested interfaces like:

https://github.com/dotnet/android-libraries/pull/956/files#diff-9da24614831c308827a1ae533ffea392c97638c261dd42bd0f5226baa136d16eR2-R6

However this may just create different API breakages.

I think so too.

Given that MAUI community toolkit is already using our existing Media3 packages, perhaps we should ask @ne0rrmatrix to weigh in.

Additionally some other people who appear to already be using these packages from the filed issues: @ArchangelWTF, @wilsonvargas, @datvm

[ne0rrmatrix]

If it fixes the issues with java constants and the various interface issues I would like to see it get merged. I am unable to use a few libraries in media 3 due to being unable to call them .

[jpobst]

I guess we don't have much choice other than API breakage. At least these are relatively new packages so they probably don't have many users yet.

[moljac]

I guess we don't have much choice other than API breakage. At least these are relatively new packages so they probably don't have many users yet.

Let's do it. Users can hang me.