Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual updates 20241003 improvements data acquisition build timings measurements (20240211) #997

Merged

Conversation

moljac
Copy link
Contributor

@moljac moljac commented Oct 3, 2024

Does this change any of the generated binding API's?

No.

Describe your contribution

Cake script modifications to add data acquisition for future investigations of build timings (measurements).

@moljac moljac requested a review from jpobst October 7, 2024 11:38
Copy link
Contributor

@jpobst jpobst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than duplicate all this code, it would probably be better to put it in a common script in build/cake and then use #load in each script to import it.

We should also consider whether bringing in a whole new dependency with ZString to build a few strings is worth it.

build.cake Outdated Show resolved Hide resolved
@moljac
Copy link
Contributor Author

moljac commented Oct 7, 2024

We should also consider whether bringing in a whole new dependency with ZString to build a few strings is worth it.

I am investigating some performance improvements XML and JSON serialization/deserialization and string manipulation (ZString in this case to see its API before doing bigger refactorings)

@moljac
Copy link
Contributor Author

moljac commented Nov 7, 2024

We should also consider whether bringing in a whole new dependency with ZString to build a few strings is worth it.

When I grab some time for my side projects I also investigte stuff we could use for our improvements. For this one I found out it is new dependency which needs to be introduced and might be obsolete when System.StringBuilder gets similar implementation, but the numbers are impressive, while the core (mostly used) API is the same as System.StringBuilder - only type needs to be changed.

This change is not proof [yet] and that's the reason I asked about benchmarks and unit-tests in /dotnet/java-interop.

@moljac moljac merged commit 0fc3107 into main Nov 14, 2024
6 checks passed
@moljac moljac deleted the mu-20240211-improvements-data-acquisition-build-timings-measurements branch November 14, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants