-
Notifications
You must be signed in to change notification settings - Fork 532
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Mono.Android] Dispose of the
RunnableImplementor
on error (#8907)
Context: 3ce27c9 Commit 3ce27c9 had a TODO: > TODO: Address [^0] and dispose of the `RunnableImplementor` instance > when `View.Post()` returns `false`. > > [^0]: we leak if `View.post(Runnable)` returns *false*. The time is now! Review all `new RunnableImplementor(…, true)` calls, and if a "removable" `RunnableImplementor` is passed to a method which can return an error such as [`Handler.post()`][0] or [`View.post()`][1], dispose of the `RunnableImplementor` instance on error. [0]: https://developer.android.com/reference/android/os/Handler#post(java.lang.Runnable) [1]: https://developer.android.com/reference/android/view/View#post(java.lang.Runnable)
- Loading branch information
Showing
2 changed files
with
42 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters