-
Notifications
You must be signed in to change notification settings - Fork 534
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[enumification][Mono.Android] Fix ChoiceMode enum generation. (#1183)
Fixes: #1170 Context: a301764 Bumps to xamarin-android-api-compatibility/master/6874e3f3 Xamarin.Android 8.1 (d15-5) provides an `Android.Widget.ChoiceMode` enum type in API-10+, used by the `Android.Widget.ListView.ChoiceMode` property. `ChoiceMode` contains the `android.widget.ListView.CHOICE_MODE_*` constants from API-10, which were moved to `android.widget.AbsListView` in API-15. Xamarin.Android 8.2 (d15-6) inadvertently *removed* the `Android.Widget.ChoiceMode` enum, because [xamarin-android/a301764a][xa-a301764a] altered the mapping of the `CHOICE_MODE` constants so that they were only bound into the `Android.Widget.ChoiceMode` enum for API-15+. [xa-a301764a]: a301764 Removing the `ChoiceMode` enum in turn caused the `ListView.ChoiceMode` property to be removed, as the `ListView.getChoiceMode()` and `ListView.setChoiceMode()` methods expected the (now nonexistent) `ChoiceMode` enum type. Update `map.csv` so that the `CHOICE_MODE_*` values are mapped to the `ChoiceMode` enum in API-10+, not API-15+, which restores the `Android.Widget.ChoiceMode` enum type and the `ListView.ChoiceMode` property.
- Loading branch information
1 parent
2fc9887
commit 8ff139f
Showing
3 changed files
with
7 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule xamarin-android-api-compatibility
updated
3 files
+3 −2 | Makefile | |
+2 −0 | inter-api-extra-v7.1-v8.0.txt | |
+4 −4 | reference/Mono.Android.xml |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters