Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regarding License info of Microsoft.Android.Ref 31.0.101-preview.9.16 #8779

Closed
Harshitha1369 opened this issue Mar 1, 2024 · 13 comments · Fixed by #8787
Closed

Regarding License info of Microsoft.Android.Ref 31.0.101-preview.9.16 #8779

Harshitha1369 opened this issue Mar 1, 2024 · 13 comments · Fixed by #8787
Assignees
Labels
Area: Installer Issues with macOS .pkg or Windows .vsix contents.

Comments

@Harshitha1369
Copy link

Android application type

Classic Xamarin.Android (MonoAndroid13.0, etc.)

Affected platform version

Xamarin Android

Description

I am trying to look license for this component - Microsoft.Android.Ref31.0.101-preview.9.16 of version (31.0.101-preview.9.16) for a project.

NuGet.org shows license info as XamarinStudio License. But in Project website, it redirects to Git repo (https://github.com/xamarin/xamarin-android) which has MIT License for other release branches.

I could not find this branch 31.0.101-preview.9.16 in Git repo unlike other release branches.

Can you please share the license Microsoft.Android.Ref31.0.101-preview.9.16 comes under? is it MIT License or XAMARIN SOFTWARE LICENSE ?

It would be helpful if you can share git repo referring to this release branch - 31.0.101-preview.9.16.

Thanks & Regards,
Harshitha

Steps to Reproduce

On Microsoft.Android.Ref31.0.101-preview.9.16

Did you find any workaround?

No response

Relevant log output

No response

@Harshitha1369 Harshitha1369 added the needs-triage Issues that need to be assigned. label Mar 1, 2024
@jpobst
Copy link
Contributor

jpobst commented Mar 1, 2024

@pjcollins @jonathanpeppers It looks like we need to update the license we are shipping in our workload packs:
https://www.nuget.org/packages/Microsoft.Android.Ref.34

@jpobst jpobst assigned jonathanpeppers and pjcollins and unassigned jpobst Mar 1, 2024
@jpobst jpobst added Area: Installer Issues with macOS .pkg or Windows .vsix contents. and removed needs-triage Issues that need to be assigned. labels Mar 1, 2024
@jonathanpeppers
Copy link
Member

There are definitely files in our MSBuild packs that are under the old Xamarin license. Anything from monodroid or androidtools, for example. We could make the license for the Ref & Runtime packs MIT, though?

I also wonder if the Xamarin license should be updated to something else now.

@jonpryor probably has comments.

@Harshitha1369
Copy link
Author

Hi,

Would like to add on here, I am looking basically only for this nuget package alone - Microsoft.Android.Ref and specifically this version - 31.0.101-preview.9.16.

On app review, this version(31.0.101-preview.9.16) is not able to categorise to which license it's under and the git repo of it is not found for this version. So I am blocked until I get the main license file of this version 31.0.101-preview.9.16.

https://www.nuget.org/packages/Microsoft.Android.Ref/31.0.101-preview.9.16
This is tagged with .Net 6.0

https://www.nuget.org/packages/Microsoft.Android.Ref/31.0.101-preview.9.16/License.

Though I upgraded all Xamarin packages, this version always comes up in mono.android.jar file. So, I need the license file link of this version(31.0.101-preview.9.16) in order to validate, if License.md file of this version in git has MIT license.

@jonathanpeppers
Copy link
Member

@Harshitha1369 I have no idea what you're trying to accomplish, but we certainly aren't going to go back and retroactively update old packages with new licenses. We could fix the license going forward in .NET 9, though.

Of course, you can always go build from source yourself and use the artifacts. The MIT-license is meant for this use-case.

That package is from 2021, but perhaps you could try building the repo on the .NET 6 release branch:

@Harshitha1369
Copy link
Author

Harshitha1369 commented Mar 1, 2024

This package here https://www.nuget.org/packages/Microsoft.Android.Ref/31.0.101-preview.9.16 -

Is this the git repo of released version 31.0.101-preview.9.16 - https://github.com/xamarin/xamarin-android/tree/release/6.0.4xx as mentioned above?

If you can share the git repo of this branch/version tagged 31.0.101-preview.9.16 is good enough for me.

@jonathanpeppers
Copy link
Member

This is the correct repo, but I have no idea what commit might correspond to 31.0.101-preview.9.16. Check if there is a git sha inside the package? You might also be able to find something in old tags or GitHub releases.

@jonathanpeppers
Copy link
Member

If you inspect Mono.Android.dll inside that package with ILSpy, it has:

[assembly: AssemblyInformationalVersion("31.0.101.16; git-rev-head:2c2302a; git-branch:release/6.0.1xx-preview9")]

@Harshitha1369
Copy link
Author

Thanks a lot. It shows here: https://nuget.info/packages/Microsoft.Android.Ref/31.0.101-preview.9.16 inside

Full Name:Mono.Android, Version=0.0.0.0, Culture=neutral, PublicKeyToken=84e04ff9cfb79065Strong Name:Yes, version 0.0.0.0AssemblyCompany:Microsoft CorporationAssemblyInformationalVersion:31.0.101.16; git-rev-head:2c2302a; git-branch:release/6.0.1xx-preview9AssemblyMetadata:Key = IsTrimmable, Value = TrueAssemblyProduct:Xamarin.AndroidAssemblyTitle:Mono.Android.dll

So It looks, it's from 6.0.1xx-preview9 branch, is that correct?

@jonpryor
Copy link
Member

jonpryor commented Mar 1, 2024

Building off of @jonathanpeppers comment, 31.0.101-preview.9.16 was built from this commit: 2c2302a

@Harshitha1369: Yes, it was built from the release/6.0.1xx-preview9 branch. Also note that this branch is for .NET 6.0 Preview 9; it is not a stable version. Additionally, .NET 6.0 is no longer supported.

How and why are you using 31.0.101-preview.9.16?

@Harshitha1369
Copy link
Author

The app is using Xamarin and is not migrated to MAUI as the app is only support and no feature enhancement.

I am not specifically downloading 31.0.101-preview.9.16 this package but it's coming from bin and obj via mono, though all Xamarin package are upgraded to latest.

@jonpryor
Copy link
Member

jonpryor commented Mar 1, 2024

@jonathanpeppers wrote:

There are definitely files in our MSBuild packs that are under the old Xamarin license. Anything from monodroid or androidtools, for example. We could make the license for the Ref & Runtime packs MIT, though?

I also wonder if the Xamarin license should be updated to something else now.

@jonpryor probably has comments.

Boy do I!

Currently, all of our packages contain the same license, and because CI contains commercial repo checkouts, the commercial license is used:

https://github.com/xamarin/xamarin-android/blob/60dbcc9fe482dddc1085c003d3a18209709cbb35/build-tools/create-packs/License.targets#L7

@pjcollins: How hard would it be to instead use different licenses for different NuGet packages? Presumably we'd want something like:

  • Microsoft.Android.Templates: MIT
  • Microsoft.Android.Ref.*: MIT (it's only reference assemblies!)
  • Microsoft.Android.Runtime.*: MIT
  • Microsoft.Android.Sdk.*: MIT for OSS builds, Commercial for CI builds (what we currently do)

If this isn't too difficult, maybe we can do this for .NET 9?

@pjcollins
Copy link
Member

pjcollins commented Mar 1, 2024

Should be easy enough to update our packs to contain different license files. For the cases where we want to include MIT (or MIT for OSS) should we just include https://github.com/xamarin/xamarin-android/blob/2bd13c4a00ae78db34663a4b9c7a4c5bfb20c344/LICENSE instead? Do we want to also update the product name in that license file to something like ".NET Android SDK"?

@jonpryor
Copy link
Member

jonpryor commented Mar 4, 2024

@pjcollins asked:

For the cases where we want to include MIT (or MIT for OSS) should we just include https://github.com/xamarin/xamarin-android/blob/2bd13c4a00ae78db34663a4b9c7a4c5bfb20c344/LICENSE instead?

Yes, I think that should be fine.

Do we want to also update the product name in that license file to something like ".NET Android SDK"?

I'm looking for guidance on this, but none of the dotnet repos I looked at have any name listed:

Maybe we should just remove the first two lines, and standardize the 5th (now 3rd) line?

Copyright (c) .NET Foundation and Contributors

pjcollins added a commit that referenced this issue Mar 6, 2024
Fixes: #8779

Updates all NuGet packages other than Microsoft.Android.Sdk to include
the MIT license at the root of the repo.

The license file name and contents have also been updated to improve
consistency with other dotnet repos.
pjcollins added a commit that referenced this issue Mar 6, 2024
Fixes: #8779

Updates all NuGet packages other than Microsoft.Android.Sdk to include
the MIT license at the root of the repo.

The license file name and contents have also been updated to improve
consistency with other dotnet repos.
@github-actions github-actions bot locked and limited conversation to collaborators Apr 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Area: Installer Issues with macOS .pkg or Windows .vsix contents.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants