[enumification] fix RemoteConference.ConnectionProperties (issue #1087) #1088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et#1087) See the github comments on the issue details. To solve the issue, we introduce a "fake" mapping fixup in enumification-helpers. Use "force-api-level" mapping information to override the correct API Level information to generate modified map(.ext).csv. methodmap.csv is also fixed to (1) remove old mapping for 24 and (2) change the mapping for 25 down to 24 too.
atsushieno
commented
Dec 7, 2017
| @@ -1777,4 +1777,4 @@ | |||
| // 27, android.os, SharedMemory, map, prot, ... is part of OsConstants. | |||
| 27, android.view.accessibility, AccessibilityRequestPreparer, ctor, requestTypes, Android.Views.Accessibility.AccessibilityRequestTypes | |||
| // android.view.ViewStructure.setInputType never appeared before - it seems Google keeps breaking API on the docs, which is rather likely they are filling doc bits by fixing their tools. | |||
| 27, android.webkit.WebViewClient, onSafeBrowsingHit, threatType, Android.Webkit.SafeBrowsingThreat | |||
| 27, android.webkit, WebViewClient, onSafeBrowsingHit, threatType, Android.Webkit.SafeBrowsingThreat | |||
There was a problem hiding this comment.
This is irrelevant, it seems that last time I seemed to have created a wrong line in this file, then noticed build breakage, and fixed the one that is actually used at build time (but wrong file, I should have fixed this too).
|
build |
jonpryor
approved these changes
Dec 13, 2017
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
May 13, 2020
Changes: xamarin/monodroid@cc88a89...52312f2 * xamarin/monodroid@52312f241: Bump to xamarin/androidtools@d5b9818 (dotnet#1092) * xamarin/monodroid@0642b39a2: Bump to xamarin/xamarin-android/master@a01756 (dotnet#1087) * xamarin/monodroid@b892bc96b: [tools/RuntimeService] base versionCode off xamarin-android (dotnet#1088)
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
May 13, 2020
Changes: xamarin/monodroid@9242fa4...e50ff9a * xamarin/monodroid@e50ff9a43: Bump to xamarin/androidtools@ff35fa96 (dotnet#1092) * xamarin/monodroid@3d4f171a0: Bump to xamarin/xamarin-android/master@a01756 (dotnet#1087) * xamarin/monodroid@5560daf55: [tools/RuntimeService] base versionCode off xamarin-android (dotnet#1088)
jonpryor
added a commit
that referenced
this pull request
May 14, 2020
Changes: xamarin/monodroid@cc88a89...52312f2 * xamarin/monodroid@52312f241: Bump to xamarin/androidtools@d5b9818 (#1092) * xamarin/monodroid@0642b39a2: Bump to xamarin/xamarin-android/master@a01756 (#1087) * xamarin/monodroid@b892bc96b: [tools/RuntimeService] base versionCode off xamarin-android (#1088)
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
May 14, 2020
Changes: xamarin/monodroid@9242fa4...e50ff9a * xamarin/monodroid@e50ff9a43: Bump to xamarin/androidtools@ff35fa96 (dotnet#1092) * xamarin/monodroid@3d4f171a0: Bump to xamarin/xamarin-android/master@a01756 (dotnet#1087) * xamarin/monodroid@5560daf55: [tools/RuntimeService] base versionCode off xamarin-android (dotnet#1088)
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
May 14, 2020
Changes: xamarin/monodroid@9242fa4...5849ea1 * xamarin/monodroid@5849ea107 [tests] Fix build from xamarin-android (dotnet#1093) * xamarin/monodroid@e50ff9a43: Bump to xamarin/androidtools@ff35fa96 (dotnet#1092) * xamarin/monodroid@3d4f171a0: Bump to xamarin/xamarin-android/master@a01756 (dotnet#1087) * xamarin/monodroid@5560daf55: [tools/RuntimeService] base versionCode off xamarin-android (dotnet#1088)
jonpryor
added a commit
that referenced
this pull request
May 14, 2020
Changes: xamarin/monodroid@9242fa4...5849ea1 * xamarin/monodroid@5849ea107 [tests] Fix build from xamarin-android (#1093) * xamarin/monodroid@e50ff9a43: Bump to xamarin/androidtools@ff35fa96 (#1092) * xamarin/monodroid@3d4f171a0: Bump to xamarin/xamarin-android/master@a01756 (#1087) * xamarin/monodroid@5560daf55: [tools/RuntimeService] base versionCode off xamarin-android (#1088)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the github comments on the issue details.
To solve the issue, we introduce a "fake" mapping fixup in enumification-helpers.
Use "force-api-level" mapping information to override the correct API Level
information to generate modified map(.ext).csv.
methodmap.csv is also fixed to (1) remove old mapping for 24 and (2) change
the mapping for 25 down to 24 too.