[build] ThirdPartyNotices.txt and $(CONFIGURATIONS) #1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An unanticipated side-effect of commit 2bd13c4 was that `make prepare` was downloading `bundle-v*.zip` for *both* [Debug and Release][0] configurations, even on the PR builder (which only builds Debug by default): [0]: https://jenkins.mono-project.com/view/Xamarin.Android/job/xamarin-android-pr-builder/2610/console Downloading `https://xamjenkinsartifact.azureedge.net/xamarin-android/xamarin-android/bin/Debug/bundle-v21-h86de098f-Debug-Darwin-libzip=1d8b1ac,llvm=bdb3a11,mono=607cbde.zip` to `/Users/builder/android-archives/.bundle-v21-h86de098f-Debug-Darwin-libzip=1d8b1ac,llvm=bdb3a11,mono=607cbde.zip.download` ... Downloading `https://xamjenkinsartifact.azureedge.net/xamarin-android/xamarin-android/bin/Release/bundle-v21-h86de098f-Release-Darwin-libzip=1d8b1ac,llvm=bdb3a11,mono=607cbde.zip` to `/Users/builder/android-archives/.bundle-v21-h86de098f-Release-Darwin-libzip=1d8b1ac,llvm=bdb3a11,mono=607cbde.zip.download`. This is unneccessary, but was a result of: $(foreach c, $(CONFIGURATIONS), \ $(eval $(call CREATE_THIRD_PARTY_NOTICES ...))) Since `ThirdPartyNotices.csproj` has a `@(ProjectReference)` to `xa-prep-tasks.csproj`, the build of which attempts to download the bundle, simply executing `ThirdPartyNotices.csproj` was triggering a bundle download, which is not desired. Rework the dependencies so that by default we only create `bin/$(CONFIGURATION)/lib/xamarin.android/ThirdPartyNotices.txt`, not one for all `$(CONFIGURATIONS)`, and move the `$(CONFIGURATIONS)` logic into `make leeroy-all`.
grendello
approved these changes
Mar 5, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An unanticipated side-effect of commit 2bd13c4 was that
make preparewas downloadingbundle-v*.zipfor bothDebug and Release configurations, even on the PR builder (which
only builds Debug by default):
This is unneccessary, but was a result of:
Since
ThirdPartyNotices.csprojhas a@(ProjectReference)toxa-prep-tasks.csproj, the build of which attempts to download thebundle, simply executing
ThirdPartyNotices.csprojwas triggering abundle download, which is not desired.
Rework the dependencies so that by default we only create
bin/$(CONFIGURATION)/lib/xamarin.android/ThirdPartyNotices.txt, notone for all
$(CONFIGURATIONS), and move the$(CONFIGURATIONS)logic into
make leeroy-all.