Fix build #1384
Merged
Fix build #1384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dellis1972
requested changes
Mar 8, 2018
| @@ -66,7 +68,7 @@ public void MenuActionLayout () | |||
| app:showAsAction = ""never"" /> | |||
|
|
|||
| </menu>"); | |||
| Monodroid.AndroidResource.UpdateXmlResource (actions, new Dictionary<string, string> (), null); | |||
| Monodroid.AndroidResource.UpdateXmlResource (actions, xmlFilePath, new Dictionary<string, string> (), null); | |||
There was a problem hiding this comment.
I think this should be Path.Combine (path, "res")
There was a problem hiding this comment.
You mean instead of actions?
There was a problem hiding this comment.
Instead of xmlFilePath. The ‘res’ Param should be te root of the resource directory. I know why this happened now. There were two PR's one altered the UpdateXmlResource signature, bother were open at the the time the commits were made so they both passed. One was merged, the other which added the test was not rebased before merging, so it looked like it was working.
grendello
force-pushed
the
fix-resourcetests-build
branch
from
6dfb1f7
to
a415064
Compare
grendello
force-pushed
the
fix-resourcetests-build
branch
from
a415064
to
9874f4a
Compare
dellis1972
approved these changes
Mar 9, 2018
jonpryor
pushed a commit
that referenced
this pull request
Mar 9, 2018
The test didn't use the correct `UpdateXmlResource` overload. This commit makes the build work.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test didn't use the correct
UpdateXmlResourceoverload. This commit makesthe build work.