[Xamarin.Android.Build.Tasks] leave classes.zip uncompressed #2140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was thinking about a couple of the slower MSBuild tasks:
- `Javac`
- `CompileToDalvik`
One thing I noticed here was that `Javac` outputs a `classes.zip`
file, and `CompileToDalvik` consumes it. It also looked like we are
using `CompressionMethod.Default` as you would expect.
So why should we compress this file at all? It seemed that was work we
could just skip and things would work fine? Presumably `dx.jar` can
work with an uncompressed `classes.zip` file faster than a compressed
one?
So I made the following changes:
- Added an option to pass in the `CompressionMethod` in `ZipArchiveEx`
- Used `CompressionMethod.Store` for creating `classes.zip`
The results on a File | New Xamarin.Forms app looked great!
Before:
3443 ms Javac 1 calls
11545 ms CompileToDalvik 1 calls
After:
3338 ms Javac 1 calls
10535 ms CompileToDalvik 1 calls
I did a `Clean` before running the `SignAndroidPackage` target on
these builds.
These savings seem pretty good! The only drawback being we use more
disk space in `$(IntermediateOutputPath)`.
|
Build logs here: ClassesZipUncompressed.zip |
dellis1972
approved these changes
Sep 5, 2018
jonpryor
pushed a commit
that referenced
this pull request
Sep 5, 2018
I was thinking about a couple of the slower MSBuild tasks:
- `Javac`
- `CompileToDalvik`
One thing I noticed here was that `Javac` outputs a `classes.zip`
file, and `CompileToDalvik` consumes it. It also looked like we are
using `CompressionMethod.Default` as you would expect.
So why should we compress this file at all? It seemed that was work we
could just skip and things would work fine? Presumably `dx.jar` can
work with an uncompressed `classes.zip` file faster than a compressed
one?
So I made the following changes:
- Added an option to pass in the `CompressionMethod` in `ZipArchiveEx`
- Used `CompressionMethod.Store` for creating `classes.zip`
The results on a File | New Xamarin.Forms app looked great!
Before:
3443 ms Javac 1 calls
11545 ms CompileToDalvik 1 calls
After:
3338 ms Javac 1 calls
10535 ms CompileToDalvik 1 calls
I did a `Clean` before running the `SignAndroidPackage` target on
these builds.
These savings seem pretty good! The only drawback being we use more
disk space in `$(IntermediateOutputPath)`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was thinking about a couple of the slower MSBuild tasks:
JavacCompileToDalvikOne thing I noticed here was that
Javacoutputs aclasses.zipfile, and
CompileToDalvikconsumes it. It also looked like we areusing
CompressionMethod.Defaultas you would expect.So why should we compress this file at all? It seemed that was work we
could just skip and things would work fine? Presumably
dx.jarcanwork with an uncompressed
classes.zipfile faster than a compressedone?
So I made the following changes:
CompressionMethodinZipArchiveExCompressionMethod.Storefor creatingclasses.zipThe results on a File | New Xamarin.Forms app looked great!
Before:
After:
I did a
Cleanbefore running theSignAndroidPackagetarget onthese builds.
These savings seem pretty good! The only drawback being we use more
disk space in
$(IntermediateOutputPath).