[Xamarin.Android.Build.Tests] Find the Microsoft.NET.Sdk #2307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (File.Exists (Path.Combine (path, "Sdk", "Sdk.props"))) | ||
| return path; | ||
| path = System.IO.Path.Combine ("/usr", "local", "share", "dotnet", "sdk"); | ||
| var dirs = Directory.GetDirectories (path, "*.*.*").OrderByDescending (x => x); |
There was a problem hiding this comment.
I have written code similar to this for xabuild, maybe could reuse it? https://github.com/xamarin/xamarin-android/blob/b78dd8bf4b1656ade4f9a46de767975400bc0101/tools/xabuild/XABuildPaths.cs#L227-L245
This looks like the code in this PR would order alphabetical, I think I was seeing that putting things in the wrong order when I wrote the above for xabuild. I think checking for Sdk.props, is probably a good idea, though.
We don't always install the `2.0.0` version of the .net SDK on Mac. So we should detect and use the most recent version. This will mean that the `NetStandardReferenceTest` might actually start running again.
jonathanpeppers
approved these changes
Oct 16, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't always install the
2.0.0version of the .net SDKon Mac. So we should detect and use the most recent version.
This will mean that the
NetStandardReferenceTestmightactually start running again.