[Xamarin.ProjectTools] check for /msbuild/ in $(FrameworkSdkRoot) #2731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Downstream in monodroid, we are still seeing a failure in
`NetStandardReferenceTest`:
Using $(FrameworkSDKRoot): /Library/Frameworks/Mono.framework/Versions/5.18.0/lib/mono/
[TESTLOG] Test NetStandardReferenceTest Complete
...
Microsoft.NET.Sdk not found:
But if I test on my machine `$(FrameworkSDKRoot)` is:
/Library/Frameworks/Mono.framework/Versions/5.18.0/lib/mono/msbuild/
Both the build machine and mine have the same version of Mono.
I think we should just make sure the path we are using includes
`/msbuild/` and append the directory if needed.
Other change:
* On Windows, it was always logging `Using $(FrameworkSDKRoot): `. So
let's not log that if it is blank.
dellis1972
approved these changes
Feb 13, 2019
|
Failing tests are |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downstream in monodroid, we are still seeing a failure in
NetStandardReferenceTest:But if I test on my machine
$(FrameworkSDKRoot)is:Both the build machine and mine have the same version of Mono.
I think we should just make sure the path we are using includes
/msbuild/and append the directory if needed.Other change:
Using $(FrameworkSDKRoot):. Solet's not log that if it is blank.