[Xamarin.Android.Build.Tasks] Check a jar has .class files in it. #2882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonpryor
reviewed
Mar 26, 2019
src/Xamarin.Android.Build.Tasks/Tasks/DetermineJavaLibrariesToCompile.cs
Outdated
Show resolved
Hide resolved
|
Failed tests seem to be Network related and nuget parallel runs related :( |
src/Xamarin.Android.Build.Tasks/Tasks/DetermineJavaLibrariesToCompile.cs
Outdated
Show resolved
Hide resolved
|
@monojenkins build |
We have found an issue with our fastdev support when it comes across a `.jar` file which does NOT contain any `.class` files. As part of our fastdev system we convert all the `.jar` files we need to `.dex` files so they can be fast deployed. If we come across a `.jar` file which does not contain any `.class` files `dx` exists with the following error no classes! This causes the build to fail. So what we need to do is check that a `.jar` has `.class` files in it. This commit also reworks some code to not use Linq in favour of a standard foreach loop.
|
Something really weird going on with the Checks summary page. It seems to be listing tests which didn't actually fail. Downloading the logs the following tests seem to be failing, not entirely sure why. |
jonathanpeppers
approved these changes
Mar 28, 2019
|
For some reason the I believe those 4 AOT failures are known at this time. |
jonpryor
pushed a commit
that referenced
this pull request
Apr 3, 2019
) We have found an issue with our fastdev support when it comes across a `.jar` file which does NOT contain any `.class` files. As part of our fastdev system we convert all the `.jar` files we need to `.dex` files so they can be fast deployed. If we come across a `.jar` file which does not contain any `.class` files, `dx` exits with the following error: no classes! This causes the build to fail. What we need to do is check that a `.jar` has `.class` files in it. This commit also reworks some code to not use Linq in favor of a standard foreach loop.
SIDOVSKY
added a commit
to SIDOVSKY/Hyperion-Xamarin.Android
that referenced
this pull request
Nov 14, 2020
Changes which lead to ignoring hyperion-known-services-xamarin: dotnet/android#2882 dotnet/android#4385 In hyperion-known-services-xaxmarin: * renamed .jar file to classes.jar * added dummy .class file Xamarin.Android still can't merge java service provider configuration files (META-INF\services\)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have found an issue with our fastdev support when
it comes across a
.jarfile which does NOT containany
.classfiles.As part of our fastdev system we convert all the
.jarfiles we need to.dexfiles so theycan be fast deployed.
If we come across a
.jarfile which does notcontain any
.classfilesdxexists with thefollowing error
This causes the build to fail. So what we need to do
is check that a
.jarhas.classfiles in it.This commit also reworks some code to not use Linq
in favour of a standard foreach loop.