[mono-2019-02][Xamarin.Android.BCL_Tests] Copy xunit tests to IntermediateOutputPath #2976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that their references can be resolved Otherwise, any referenced assemblies that are only used by the xunit testsuites will not be included in the APK.
alexischr
added
the
full-mono-integration-build
grendello
approved these changes
Apr 15, 2019
alexischr
approved these changes
Apr 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so that their references can be resolved
Otherwise, any referenced assemblies that are only used by the xunit testsuites
will not be included in the APK.
I'm not sure if this is the best way - with this the XUnit test assemblies all end up inside the APK in the
assemblies/folder (the same way that all the NUnit test assemblies already do) - which means they're duplicated in theXamarin.Android.BCL_Test.apk- they're included once more in thebcl-tests.zipthat's embedded as a resource in theassemblies/Xamarin.Android.Bcl_Tests.dllinside the APK.But I've been told that that's a know issue that will be dealt with separately.