[Xamarin.Android.Build.Tasks] Split up XA5101 errors and make them localizable #4228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendanzagaeski
requested review from
dellis1972,
jonathanpeppers and
jonpryor
as code owners
…calizable Context: 0342fe5 Context: https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1009374/ Give the XA5101 errors in `NdkUtil` their own new error codes so they can be distinguished from the `NdkUtilOld` errors in telemetry. Move the message strings for XA5101 and the other new error codes to the `.resx` file so that they are localizable.
brendanzagaeski
force-pushed
the
loc-7
branch
from
60e4523 to
9bf023d
Compare
dellis1972
approved these changes
Feb 7, 2020
jonathanpeppers
approved these changes
Feb 7, 2020
|
Hmm. I see the build failed this time because of: So the tests still didn't run for this PR. I think there was some chat today about possible strategies to give the builds different IDs on retries. In the mean time, I'll just add an empty commit to this branch to try the build once more. |
jonpryor
pushed a commit
that referenced
this pull request
Feb 11, 2020
Context: 0342fe5 Context: https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1009374/ Give the XA5101 errors in `NdkUtil` their own new error codes so they can be distinguished from the `NdkUtilOld` errors in telemetry. Move the message strings for XA5101 and the other new error codes to the `.resx` file so that they are localizable.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: 0342fe5
Context: https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1009374/
Give the XA5101 errors in
NdkUtiltheir own new error codes so theycan be distinguished from the
NdkUtilOlderrors in telemetry.Move the message text for XA5101 and the other new error codes into the
.resxfile so that they are ready for localization.