Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[illink] Do not always preserve CharSequence #5363

Merged
merged 4 commits into from
Dec 4, 2020

Conversation

radekdoulik
Copy link
Member

@radekdoulik radekdoulik commented Dec 3, 2020

Part of #5167

Added dynamic dependency where needed.

Removed API from BuildReleaseArm64False test:

apkdiff before.apk after.apk
...
Type Android.Runtime.CharSequence
  -             Method public static SIGERR ToLocalJniHandle (System.Collections.Generic.IEnumerable`1<char>)
...

Part of dotnet#5167

Added dynamic dependency where needed.

Removed API from `BuildReleaseArm64False` test:

    Type Android.Runtime.CharSequence
      -             Method public static SIGERR ToLocalJniHandle (System.Collections.Generic.IEnumerable`1<char>)
@radekdoulik radekdoulik requested a review from jonpryor as a code owner December 3, 2020 12:05
@jonpryor
Copy link
Member

jonpryor commented Dec 3, 2020

What's the illinkanalyzer command that gave you the output provided in the PR message?

@radekdoulik
Copy link
Member Author

What's the illinkanalyzer command that gave you the output provided in the PR message?

It is part of the default apkdiff output.

@jonpryor jonpryor merged commit a74fe4a into dotnet:master Dec 4, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jan 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants