[illink] Do not preserve ConstructorBuilder #5364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of dotnet#5167 The type is not accessed by reflection. It can also be made static, but that is already part of dotnet#5360 Removed API from BuildReleaseArm64False test: Type Android.Runtime.ConstructorBuilder - Method public SIGERR .ctor ()
|
What's the |
|
Do we need to preserve |
I guess we can. I could try to use relevant parts in the "current/legacy" preserve files as well, once I am done with .NET5/6 |
|
Squash-and-merge summary: Squash-and-merge body: Context: https://github.com/xamarin/xamarin-android/issues/5167
The `Android.Runtime.ConstructorBuilder` type is not accessed
by reflection, and does not need to be fully preserved by the linker. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #5167
The type is not accessed by reflection. It can also be made static,
but that is already part of #5360
Removed API from BuildReleaseArm64False test: