-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default InvariantGlobalization in Xamarin Android #5605
Conversation
This allows for unnecessary code to be trimmed by default in an app. See dotnet/runtime#47999.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@eerhardt : why isn't |
The behavior of
For app models that are trimmed (Blazor WASM, Xamarin), this setting allows the code that is only used when I made the same changes in Blazor WASM And @marek-safar requested I make the same change to Xamarin. |
Added |
Ah, but there will be no difference yet. We should bump net6 version too. |
I tried to measure it with |
This is no longer needed since dotnet/runtime#53453 fixed the issue this was working around. Bringing back the original optimization in dotnet#5605.
Context: #5954 (comment) Context: #5605 This partially reverts da536fc. In da536fc, we started seeing a crash around `$(InvariantGlobalization)`. This is no longer needed since dotnet/runtime#53453 fixed the issue. Bringing back the original optimization in #5605.
This allows for unnecessary code to be trimmed by default in an app. See dotnet/runtime#47999.