[xaprepare] don't install microsoft-net-runtime-android workload #6114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: dotnet#6112 (review) The .NET Preview 7 bump is failing with: Running: /Users/builder/Library/Android/dotnet/dotnet "workload" "install" "microsoft-net-runtime-android" "--skip-manifest-update" "--verbosity" "diag" stderr | Workload with id microsoft-net-runtime-android is not recognized. However, it was a bug in the `dotnet workload install` command that we were even able to install this workload in the first place! The concept behind "abstract" workloads is they are not user visible in any way. They're meant to be an implementation detail. In 0150bbb, I setup `xaprepare` to install `microsoft-net-runtime-android`, but we don't actually even need to do this. We can simply update the `sdk-manifest` for this pack, so the version matches `$(DotNetRuntimePacksVersion)`. `microsoft-net-runtime-android` will get installed later during the `ExtractWorkloadPacks` target: https://github.com/xamarin/xamarin-android/blob/c1a2ee70214e86757541b5759c9ed54941bd4680/build-tools/create-packs/Directory.Build.targets#L119-L122 Since `android` and `android-aot` extend `microsoft-net-runtime-android`, this step will install it.
grendello
approved these changes
Jul 22, 2021
jonpryor
pushed a commit
that referenced
this pull request
Jul 22, 2021
Context: #6112 (review) The .NET Preview 7 bump is failing with: Running: /Users/builder/Library/Android/dotnet/dotnet "workload" "install" "microsoft-net-runtime-android" "--skip-manifest-update" "--verbosity" "diag" stderr | Workload with id microsoft-net-runtime-android is not recognized. However, it was a bug in the `dotnet workload install` command that allowed us to even install this workload in the first place! The concept concept behind "abstract" workloads is they are not user visible in any way; they're meant to be an implementation detail. In commit 0150bbb, I setup `xaprepare` to install the `microsoft-net-runtime-android` workload, but we don't actually even need to do this. We can simply update the `sdk-manifest` for this pack, so that the version matches `$(DotNetRuntimePacksVersion)`. The `microsoft-net-runtime-android` workload will get installed later during the `ExtractWorkloadPacks` target, as part of installing the `android` or `android-aot` workloads: https://github.com/xamarin/xamarin-android/blob/c1a2ee70214e86757541b5759c9ed54941bd4680/build-tools/create-packs/Directory.Build.targets#L119-L122 Since `android` and `android-aot` extend `microsoft-net-runtime-android`, this step will install it.
jonathanpeppers
deleted the
dotnet-workload-install-microsoft-net-runtime-android
branch
thaystg
added a commit
to thaystg/xamarin-android
that referenced
this pull request
Jul 23, 2021
…er_unhandled_exception * origin/main: Bump to dotnet/installer@19943da 6.0.100-rc.1.21372.10 (dotnet#6110) [xaprepare] don't install microsoft-net-runtime-android workload (dotnet#6114) [Mono.Android] Use `mono_unhandled_exception` for NET6 (dotnet#6104) Bump to dotnet/installer@9c463710 6.0.100-rc.1.21369 (dotnet#6072) Bump to xamarin/xamarin-android-binutils/2.37-XA.1@77618674 v2.37 (dotnet#6096) [Mono.Android.Export] Fix DynamicDependency to JavaArray (dotnet#6105) [xaprepare] always delete ~/android-toolchain/dotnet (dotnet#6098) [CI] Add nuget to msi conversion and VS insert stage (dotnet#6030) [build] delete platform-31 folder on test jobs (dotnet#6103)
jonpryor
pushed a commit
to jonpryor/xamarin-android
that referenced
this pull request
Aug 25, 2021
…net#6114) Context: dotnet#6112 (review) The .NET Preview 7 bump is failing with: Running: /Users/builder/Library/Android/dotnet/dotnet "workload" "install" "microsoft-net-runtime-android" "--skip-manifest-update" "--verbosity" "diag" stderr | Workload with id microsoft-net-runtime-android is not recognized. However, it was a bug in the `dotnet workload install` command that allowed us to even install this workload in the first place! The concept concept behind "abstract" workloads is they are not user visible in any way; they're meant to be an implementation detail. In commit 0150bbb, I setup `xaprepare` to install the `microsoft-net-runtime-android` workload, but we don't actually even need to do this. We can simply update the `sdk-manifest` for this pack, so that the version matches `$(DotNetRuntimePacksVersion)`. The `microsoft-net-runtime-android` workload will get installed later during the `ExtractWorkloadPacks` target, as part of installing the `android` or `android-aot` workloads: https://github.com/xamarin/xamarin-android/blob/c1a2ee70214e86757541b5759c9ed54941bd4680/build-tools/create-packs/Directory.Build.targets#L119-L122 Since `android` and `android-aot` extend `microsoft-net-runtime-android`, this step will install it.
jonpryor
pushed a commit
that referenced
this pull request
Aug 26, 2021
Context: #6112 (review) The .NET Preview 7 bump is failing with: Running: /Users/builder/Library/Android/dotnet/dotnet "workload" "install" "microsoft-net-runtime-android" "--skip-manifest-update" "--verbosity" "diag" stderr | Workload with id microsoft-net-runtime-android is not recognized. However, it was a bug in the `dotnet workload install` command that allowed us to even install this workload in the first place! The concept concept behind "abstract" workloads is they are not user visible in any way; they're meant to be an implementation detail. In commit 0150bbb, I setup `xaprepare` to install the `microsoft-net-runtime-android` workload, but we don't actually even need to do this. We can simply update the `sdk-manifest` for this pack, so that the version matches `$(DotNetRuntimePacksVersion)`. The `microsoft-net-runtime-android` workload will get installed later during the `ExtractWorkloadPacks` target, as part of installing the `android` or `android-aot` workloads: https://github.com/xamarin/xamarin-android/blob/c1a2ee70214e86757541b5759c9ed54941bd4680/build-tools/create-packs/Directory.Build.targets#L119-L122 Since `android` and `android-aot` extend `microsoft-net-runtime-android`, this step will install it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #6112 (review)
The .NET Preview 7 bump is failing with:
However, it was a bug in the
dotnet workload installcommand that wewere even able to install this workload in the first place! The
concept behind "abstract" workloads is they are not user visible in
any way. They're meant to be an implementation detail.
In 0150bbb, I setup
xaprepareto installmicrosoft-net-runtime-android, but we don't actually even need to dothis. We can simply update the
sdk-manifestfor this pack, so theversion matches
$(DotNetRuntimePacksVersion).microsoft-net-runtime-androidwill get installed later during theExtractWorkloadPackstarget:https://github.com/xamarin/xamarin-android/blob/c1a2ee70214e86757541b5759c9ed54941bd4680/build-tools/create-packs/Directory.Build.targets#L119-L122
Since
androidandandroid-aotextendmicrosoft-net-runtime-android, this step will install it.