-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Xamarin.Android.Build.Tasks] Microsoft.Resource.Designer Assembly #6427
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
ca4ae38
First Pass at using Resource Designer assembly [WIP]
dellis1972 1d11bae
Fix test failures
dellis1972 66b433a
Fix failing test
dellis1972 a307755
Fix make all-tests
dellis1972 fb0bccf
Fix apkdesc files
dellis1972 b0f76b6
Update Unit Test feed
dellis1972 ab03d41
use AddNuGetSourcesForOlderTargetFrameworks
dellis1972 817016e
Test .net8
dellis1972 5e2d6bb
fix merge conflicts
dellis1972 b080be0
Change to XA1034
dellis1972 d669fd6
Update based on feedback
dellis1972 6837c90
Back out some unit test changes
dellis1972 c944112
Fix build error
dellis1972 f48c1f5
Use Flush to make sure we have data in the stream
dellis1972 ae51be4
Fix apkdesc
dellis1972 94f399a
update apkdesc
dellis1972 ae8764c
ff
dellis1972 a765bea
Fix indentation formatting
jonpryor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
--- | ||
title: Xamarin.Android error XA1034 | ||
description: XA1034 error code | ||
ms.date: 13/12/2022 | ||
--- | ||
# Xamarin.Android error XA1034 | ||
|
||
## Example messages | ||
|
||
``` | ||
Your project references 'Foo.dll' which uses the `_Microsoft.Android.Resource.Designer` assembly, but you do not have this feature enabled. Please set the `AndroidUseDesignerAssembly` MSBuild property to `true` in your project file. | ||
``` | ||
|
||
## Solution | ||
|
||
Edit your csproj directly and change the 'AndroidUseDesignerAssembly' to `True`. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 changes: 33 additions & 0 deletions
33
build-tools/xaprepare/xaprepare/ThirdPartyNotices/StrongNameSigner.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
using System; | ||
using System.Collections.Generic; | ||
using System.IO; | ||
|
||
namespace Xamarin.Android.Prepare | ||
{ | ||
[TPN] | ||
class StrongNameSigner_TPN : ThirdPartyNotice | ||
{ | ||
static readonly Uri url = new Uri ("https://github.com/brutaldev/StrongNameSigner/"); | ||
|
||
public override string LicenseFile => string.Empty; | ||
public override string Name => "brutaldev/StrongNameSigner"; | ||
public override Uri SourceUrl => url; | ||
public override string LicenseText => @" | ||
Copyright (c) Werner van Deventer (werner@brutaldev.com). All rights reserved. | ||
|
||
Licensed under the Apache License, Version 2.0 (the 'License'); you | ||
may not use this file except in compliance with the License. You may | ||
obtain a copy of the License at | ||
|
||
http://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an 'AS IS' BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or | ||
implied. See the License for the specific language governing permissions | ||
and limitations under the License. | ||
"; | ||
|
||
public override bool Include (bool includeExternalDeps, bool includeBuildDeps) => includeExternalDeps; | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The last concern I have is this comment. Do we need to ask other teams about this? .NET MAUI team at least?
Any existing libraries from Telerik/DevExpress, will need to be updated to work in .NET 8? (If those are mostly UI, they would likely use a value from
Resource.designer.cs
)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
old style Assemblies will be auto upgraded by the linker during a build. So existing NuGet packages will work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, so you only hit an issue if you turn the setting off, got it.