Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] .yaml changes for private fork & NuGet feeds #6594

Merged
merged 3 commits into from
Jan 14, 2022

Conversation

jonathanpeppers
Copy link
Member

This brings over more changes from xamarin-android-private.

With these changes, the private fork should be able to build main and push builds to an internal feed.

I also set $(TeamName), which isn't used here -- but will be needed when consuming internal .NET builds on the private fork.

This brings over more changes from `xamarin-android-private`.

With these changes, the private fork should be able to build `main` and push builds to an internal feed.

I also set `$(TeamName)`, which isn't used here -- but will be needed when consuming internal .NET builds on the private fork.
@jonathanpeppers
Copy link
Member Author

jonathanpeppers commented Dec 22, 2021

Testing:

@pjcollins
Copy link
Member

I think we have a bug in this script for build pipelines which contain spaces in the name - https://github.com/xamarin/yaml-templates/blob/38e978a718e7f1d514cb6763ce30a3b888af3a69/upload-to-storage.yml#L46. The easiest fix would be to rename the pipeline to Xamarin.Android-Private (and update pipeline name checks in yaml accordingly).

@jonathanpeppers
Copy link
Member Author

Renamed to Xamarin.Android-Private new private build here

@jonathanpeppers
Copy link
Member Author

I renamed it, now need to request new signing approval...

@pjcollins
Copy link
Member

Oof, I guess for some reason that approval list is keyed off actual name instead of the pipeline ID 😢

@jonathanpeppers
Copy link
Member Author

This is still waiting signing approval, maybe we'll get that soon in the new year.

##[error]Xamarin.Android-Private is not approved for signing in https://devdiv.visualstudio.com/. Please read https://devdiv.visualstudio.com/DevDiv/_wiki/wikis/DevDiv.wiki/650/MicroBuild-Signing

@jonathanpeppers
Copy link
Member Author

It seems like it might have gotten approved and it didn't notify me?

Running now: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=5627305&view=results

@jonathanpeppers jonathanpeppers marked this pull request as ready for review January 14, 2022 04:01
@jonathanpeppers
Copy link
Member Author

The build on the private side appears to be working well enough to sign packages and run tests. 👍

Copy link
Member

@pjcollins pjcollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the minor duplication above, LGTM

@jonathanpeppers jonathanpeppers merged commit 9fc53bb into main Jan 14, 2022
@jonathanpeppers jonathanpeppers deleted the internal-fork branch January 14, 2022 20:08
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants