-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[build] .yaml changes for private fork & NuGet feeds #6594
Conversation
This brings over more changes from `xamarin-android-private`. With these changes, the private fork should be able to build `main` and push builds to an internal feed. I also set `$(TeamName)`, which isn't used here -- but will be needed when consuming internal .NET builds on the private fork.
Testing: |
There is a failure signing on private fork: Compared to public: |
I think we have a bug in this script for build pipelines which contain spaces in the name - https://github.com/xamarin/yaml-templates/blob/38e978a718e7f1d514cb6763ce30a3b888af3a69/upload-to-storage.yml#L46. The easiest fix would be to rename the pipeline to |
Renamed to |
I renamed it, now need to request new signing approval... |
Oof, I guess for some reason that approval list is keyed off actual name instead of the pipeline ID 😢 |
This is still waiting signing approval, maybe we'll get that soon in the new year.
|
It seems like it might have gotten approved and it didn't notify me? Running now: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=5627305&view=results |
The build on the private side appears to be working well enough to sign packages and run tests. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the minor duplication above, LGTM
This brings over more changes from
xamarin-android-private
.With these changes, the private fork should be able to build
main
and push builds to an internal feed.I also set
$(TeamName)
, which isn't used here -- but will be needed when consuming internal .NET builds on the private fork.