Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to r8 3.0.73 #6620

Merged
merged 2 commits into from
Jan 7, 2022
Merged

Bump to r8 3.0.73 #6620

merged 2 commits into from
Jan 7, 2022

Conversation

jonathanpeppers
Copy link
Member

78dd021 introduced the `MultiDexR8ConfigWithNoCodeShrinking(false)`
test that asserts we get the warning:

    R8 : warning : Missing class: java.lang.ClassValue

The latest version of r8 no longer emits this warning, so Google must
have *fixed* something here.

The test still seems useful to build a multi-dex application with a
`@(ProguardConfiguration)` item, so let's drop one test case and just
assert that the warning isn't there. The test is no longer
parameterized.
@jonathanpeppers
Copy link
Member Author

The one performance test that failed, I don't see anything related to this change:

image

<D8/> or <R8/> didn't run, so going to merge.

@jonathanpeppers jonathanpeppers merged commit 862ea39 into dotnet:main Jan 7, 2022
@jonathanpeppers jonathanpeppers deleted the r8-3.0.73 branch January 7, 2022 18:24
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants