[Mono.Android] add "built-in" delegate for MAUI+non-Shell #7267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: dotnet/maui@15df4ed Fixes: dotnet#7212 In the app we're recording AOT profiles for .NET MAUI, we added a `FlyoutPage` and navigated to it. This was good because it added common scenarios to the profile: * Navigation from one page to another * A non-Shell API, `FlyoutPage` * `FlyoutPage` also implicitly uses `NavigationPage`? This caused the app to start using System.Reflection.Emit and logging: 08-16 09:46:24.687 31517 31517 D monodroid-assembly: Falling back to System.Reflection.Emit for delegate type '_JniMarshal_PPIZI_L': IntPtr n_OnCreateAnimation_IZI(IntPtr, IntPtr, Int32, Boolean, Int32) I added a case for `_JniMarshal_PPIZI_L`, this log message is now gone when I build and run this app. I think this should be the last one of these we add, unless one appears from either: * `dotnet new maui` or `dotnet new maui-blazor` * [.NET Podcast app][0] [0]: https://github.com/microsoft/dotnet-podcasts
jonathanpeppers
force-pushed
the
_JniMarshal_PPIZI_L
branch
from
609ef2c to
a2a9814
Compare
For the non-shell path I just made sure to include all non-shell page types (FlyoutPage, TabbedPage, NavigationPage) so that all AOT paths would be covered by whatever combination of these three pages that users will use. |
jonathanpeppers
added a commit
that referenced
this pull request
Aug 22, 2022
Fixes: #7212 Context: 32cff43 Context: dotnet/maui@15df4ed In the app we're recording AOT profiles for .NET MAUI, we added a `FlyoutPage` and navigated to it. This was good because it added common scenarios to the profile: * Navigation from one page to another * A non-Shell API, `FlyoutPage` * `FlyoutPage` also implicitly uses `NavigationPage`? This caused the app to start using System.Reflection.Emit and logging: D monodroid-assembly: Falling back to System.Reflection.Emit for delegate type '_JniMarshal_PPIZI_L': IntPtr n_OnCreateAnimation_IZI(IntPtr, IntPtr, Int32, Boolean, Int32) I added a case for `_JniMarshal_PPIZI_L`, and this log message is now gone when I build and run this app. I think this should be the last one of these we add, unless one appears from either: * `dotnet new maui` or `dotnet new maui-blazor` * [.NET Podcast app][0] [0]: https://github.com/microsoft/dotnet-podcasts
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Aug 23, 2022
* main: Bump r8 from 3.3.28 to 3.3.75 (dotnet#7292) [Xamarin.Android.Build.Tasks] Pass `hybrid` to AOT, if enabled (dotnet#7263) Bump to lz4/lz4@5ff83968 [v1.9.4] (dotnet#7262) [Mono.Android] add "built-in" delegate for MAUI+non-Shell (dotnet#7267)
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Aug 23, 2022
* mm-runtime: Implement some requested changes Bump r8 from 3.3.28 to 3.3.75 (dotnet#7292) [Xamarin.Android.Build.Tasks] Pass `hybrid` to AOT, if enabled (dotnet#7263) Bump to lz4/lz4@5ff83968 [v1.9.4] (dotnet#7262) [Mono.Android] add "built-in" delegate for MAUI+non-Shell (dotnet#7267)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: dotnet/maui@15df4ed
Fixes: #7212
In the app we're recording AOT profiles for .NET MAUI, we added a
FlyoutPageand navigated to it. This was good because it addedcommon scenarios to the profile:
FlyoutPageFlyoutPagealso implicitly usesNavigationPage?This caused the app to start using System.Reflection.Emit and logging:
I added a case for
_JniMarshal_PPIZI_L, this log message is now gonewhen I build and run this app.
I think this should be the last one of these we add, unless one
appears from either:
dotnet new mauiordotnet new maui-blazor