[Xamarin.Android.Build.Tasks] Restore @(AndroidEnvironment) #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a failure within `EnvironmentTests.EnvironmentVariablesFromLibraryProjectsAreMerged` (commit ea6b9b4): the `@(AndroidEnvironment)` from the library project is not merged into the App `.apk`: Expected: null But was: "Well, hello there!" (The arguments were in the wrong order. Oops.) The cause for this is due to `<ResolveLibraryProjectImports/>` attempts to avoid duplicate work; [from the build log][0] [0]: https://jenkins.mono-project.com/view/Xamarin.Android/job/xamarin-android/526/consoleText Task "ResolveLibraryProjectImports" Assemblies: .../xamarin-android/bin/TestDebug//LibraryResources.dll Skipped resource lookup for .../xamarin-android/bin/TestDebug/LibraryResources.dll: extracted files are up to date ResolvedEnvironmentFiles: *Because* `LibraryResources.dll` was skipped, the `@(AndroidEnvironment)` entries from `LibraryResources.dll` were also skipped! Doh! Update the `<ResolveLibraryProjectImports/>` task so that when resource extraction for an assembly is skipped, we remember to add the already-extracted `@(AndroidEnvironment)` values.
dellis1972
approved these changes
Aug 11, 2017
Merged
jonpryor
added a commit
that referenced
this pull request
Aug 11, 2017
We have a failure within `EnvironmentTests.EnvironmentVariablesFromLibraryProjectsAreMerged` (commit ea6b9b4): the `@(AndroidEnvironment)` from the library project is not merged into the App `.apk`: Expected: null But was: "Well, hello there!" (The arguments were in the wrong order. Oops.) The cause for this is due to `<ResolveLibraryProjectImports/>` attempts to avoid duplicate work; [from the build log][0] [0]: https://jenkins.mono-project.com/view/Xamarin.Android/job/xamarin-android/526/consoleText Task "ResolveLibraryProjectImports" Assemblies: .../xamarin-android/bin/TestDebug//LibraryResources.dll Skipped resource lookup for .../xamarin-android/bin/TestDebug/LibraryResources.dll: extracted files are up to date ResolvedEnvironmentFiles: *Because* `LibraryResources.dll` was skipped, the `@(AndroidEnvironment)` entries from `LibraryResources.dll` were also skipped! Doh! Update the `<ResolveLibraryProjectImports/>` task so that when resource extraction for an assembly is skipped, we remember to add the already-extracted `@(AndroidEnvironment)` values.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a failure within
EnvironmentTests.EnvironmentVariablesFromLibraryProjectsAreMerged(commit ea6b9b4): the
@(AndroidEnvironment)from the libraryproject is not merged into the App
.apk:(The arguments were in the wrong order. Oops.)
The cause for this is due to
<ResolveLibraryProjectImports/>attempts to avoid duplicate work; from the build log
Because
LibraryResources.dllwas skipped, the@(AndroidEnvironment)entries fromLibraryResources.dllwere alsoskipped! Doh!
Update the
<ResolveLibraryProjectImports/>task so that whenresource extraction for an assembly is skipped, we remember to add the
already-extracted
@(AndroidEnvironment)values.