[Xamarin.Android.Build.Tasks] Seeing a new seemingly DesignTimeBuild related build failure when invoking the Rebuild msbuild target #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…related build failure when invoking the Rebuild msbuild target Context https://bugzilla.xamarin.com/show_bug.cgi?id=58682 The `$(DesignTimeBuild)` value was empty when running under mac. This cuases the error error MSB4044: The "GetAdditionalResourcesFromAssemblies" task was not given a value for the required parameter "DesignTimeBuild". So we need to make sure that the value is set before we get to `GetAdditionalResourcesFromAssemblies`. The reason we got the error is before we used `$(DesignTimeBuild)` only in conditionals. However when moving to use it as a property of a task it cannot be empty. So we need to make sure we call `_SetupDesignTimeBuildForBuild` early in the build process.
|
build |
jonpryor
pushed a commit
to jonpryor/xamarin-android
that referenced
this pull request
Sep 11, 2017
…tnet#757) Context: https://bugzilla.xamarin.com/show_bug.cgi?id=58682 Seeing a new seemingly DesignTimeBuild-related build failure when invoking the `Rebuild` msbuild target. The `$(DesignTimeBuild)` value was empty when running under mac. This cuases the error error MSB4044: The "GetAdditionalResourcesFromAssemblies" task was not given a value for the required parameter "DesignTimeBuild". So we need to make sure that the value is set before we get to `GetAdditionalResourcesFromAssemblies`. The reason we got the error is before we used `$(DesignTimeBuild)` only in conditionals. However when moving to use it as a property of a task it cannot be empty. So we need to make sure we call `_SetupDesignTimeBuildForBuild` early in the build process.
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Dec 14, 2020
Changes: dotnet/java-interop@99897b2...2f62ffd * dotnet/java-interop@2f62ffd4: [Xamarin.Android.Tools.Bytecode] @not-null androidx.annotation.NonNull (dotnet#759) * dotnet/java-interop@7c1ad51c: [java-source-utils] Properly represent unresolved types (dotnet#758) * dotnet/java-interop@c1bc5c83: [java-source-utils] Better support orphaned Javadocs (dotnet#757) * dotnet/java-interop@0cb8e2d3: [Xamarin.Android.Tools.ApiXmlAdjuster] Use Dictionaries for perf (dotnet#756) * dotnet/java-interop@99f89905: [build] Fix for MSBuild 16.8 (dotnet#755)
jonpryor
added a commit
that referenced
this pull request
Dec 15, 2020
Changes: dotnet/java-interop@99897b2...2f62ffd * dotnet/java-interop@2f62ffd4: [Xamarin.Android.Tools.Bytecode] @not-null androidx.annotation.NonNull (#759) * dotnet/java-interop@7c1ad51c: [java-source-utils] Properly represent unresolved types (#758) * dotnet/java-interop@c1bc5c83: [java-source-utils] Better support orphaned Javadocs (#757) * dotnet/java-interop@0cb8e2d3: [Xamarin.Android.Tools.ApiXmlAdjuster] Use Dictionaries for perf (#756) * dotnet/java-interop@99f89905: [build] Fix for MSBuild 16.8 (#755)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context https://bugzilla.xamarin.com/show_bug.cgi?id=58682
The
$(DesignTimeBuild)value was empty when running under mac.This cuases the error
So we need to make sure that the value is set before we get to
GetAdditionalResourcesFromAssemblies. The reason we got the erroris before we used
$(DesignTimeBuild)only in conditionals. Howeverwhen moving to use it as a property of a task it cannot be empty.
So we need to make sure we call
_SetupDesignTimeBuildForBuildearly in the build process.