[Xamarin.Android.Build.Tasks] avoid File.Exists() check
#7621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`dotnet-trace` output of a `dotnet new maui` app:
dotnet trace collect --format speedscope -- C:\src\xamarin-android\bin\Release\dotnet\dotnet.exe build -bl --no-restore bar.csproj
Shows an interesting case of `File.Exists()`:
49.88ms xamarin.android.build.tasks!Xamarin.Android.Tasks.FilterAssemblies.RunTask()
8.09ms System.Private.CoreLib.il!System.IO.File.Exists(class System.String)
The common case is the files always exist. The rare case appears to be
783ac9e, which would be when something like a `<ProjectReference/>`
doesn't exist.
Instead of calling `File.Exists()` on every .NET assembly (likely done
multiple times in a build), we can handle `FileNotFoundException` and
take appropriate action.
This will save ~8ms on *every* build, and we should get the exact same
behavior as before. Potentially larger projects could even save more.
dellis1972
approved these changes
Dec 8, 2022
|
@jonathanpeppers I suspect the |
|
Yeah So that might be why I didn't see this one. |
|
Ok, I need to handle |
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Jan 4, 2023
* main: [Xamarin.Android.Build.Tasks] use %(TrimmerRootAssembly.RootMode) All (dotnet#7651) Bump to dotnet/installer@47a747f 8.0.100-alpha.1.22616.7 (dotnet#7647) Bump to dotnet/installer@167a4ed 8.0.100-alpha.1.22611.1 (dotnet#7630) Bump to xamarin/Java.Interop/main@f8d77fa (dotnet#7638) [ci] Fix Designer test paths (dotnet#7635) [Xamarin.Android.Build.Tasks] perf improvements for LlvmIrGenerator (dotnet#7626) [Xamarin.Android.Build.Tasks] AutoImport `*.webp` files (dotnet#7601) Localized file check-in by OneLocBuild Task (dotnet#7632) Bump $(ProductVersion) to 13.2.99 Bump to xamarin/monodroid@c0c933b7 (dotnet#7633) [Xamarin.Android.Build.Tasks] Fix aapt_rules.txt corruption (dotnet#7587) [Xamarin.Android.Build.Tasks] Add XA1031 error (dotnet#7448) Bump to xamarin/Java.Interop/main@149d70f (dotnet#7625) [CODEOWNERS] More updates to CODEOWNERS (dotnet#7628) [Xamarin.Android.Build.Tasks] avoid `File.Exists()` check (dotnet#7621)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dotnet-traceoutput of adotnet new mauiapp:Shows an interesting case of
File.Exists():The common case is the files always exist. The rare case appears to be 783ac9e, which would be when something like a
<ProjectReference/>doesn't exist.Instead of calling
File.Exists()on every .NET assembly (likely done multiple times in a build), we can handleFileNotFoundExceptionand take appropriate action.This will save ~8ms on every build, and we should get the exact same behavior as before. Potentially larger projects could even save more.