Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GetAndroidDependencies] Add Jdk dependency info #8651

Merged
merged 7 commits into from
Jan 31, 2024
Merged

Conversation

pjcollins
Copy link
Member

@pjcollins pjcollins commented Jan 18, 2024

Context: dotnet/android-tools@ed102fc

Updates <GetAndroidDependencies/> to output a new @(JavaDependency)
item group if $(AndroidInstallJavaDependencies) is set to true.
This group currently contains one item:

JavaDependency
  jdk
    Version = 17.0.8.1

This output will be used by <InstallAndroidDependencies/> to install
the our recommended version of the Java SDK.

@pjcollins pjcollins marked this pull request as ready for review January 25, 2024 20:49
@pjcollins pjcollins requested a review from tondat January 25, 2024 20:49
Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there way to update an existing test to check this works?

@pjcollins
Copy link
Member Author

Is there way to update an existing test to check this works?

I tried to update an existing test to check for the new JavaDependency output, hopefully that will work. I was also planning on adding tests for installation once https://github.com/xamarin/android-sdk-installer/pull/913 makes its way through the dependency chain.

@pjcollins pjcollins marked this pull request as draft January 29, 2024 19:05
@pjcollins pjcollins marked this pull request as ready for review January 29, 2024 22:27
@pjcollins pjcollins merged commit 80ee320 into main Jan 31, 2024
47 checks passed
@pjcollins pjcollins deleted the dev/pjc/installjdk branch January 31, 2024 04:48
grendello added a commit that referenced this pull request Jan 31, 2024
* main:
  [GetAndroidDependencies] Add Jdk dependency info (#8651)
grendello added a commit that referenced this pull request Feb 7, 2024
* main:
  Bump to dotnet/installer@fb7b9a4b9e 9.0.100-preview.2.24106.6 (#8700)
  [Mono.Android] Cache `Profiles/api-34.xml` contents (#8679)
  [monodroid] typemaps may need to load assemblies (#8625)
  Bump $(AndroidNetPreviousVersion) to 34.0.79 (#8693)
  Bump to xamarin/java.interop/main@07c73009 (#8681)
  Bump to dotnet/installer@1c496970b7 9.0.100-preview.2.24078.1 (#8685)
  [GetAndroidDependencies] Add Jdk dependency info (#8651)
  [xaprepare] Add support for newer SparkyLinux (#8684)
grendello added a commit that referenced this pull request Feb 14, 2024
* main: (116 commits)
  [tmt] Update to work with current `libxamarin-app.so` (#8694)
  [Xamarin.Android.Build.Tasks] remove `$(AndroidSupportedAbis)` from `build.props` (#8717)
  [Xamarin.Android.Build.Tasks] BannedApiAnalyzers for Resolve() (#8715)
  Bump to xamarin/Java.Interop/main@dfcbd670 (#8714)
  [monodroid] C++ tweaks and legacy code cleanup (#8638)
  Bump to xamarin/xamarin-android-tools/main@a698a33 (#8710)
  [readme] Add `d17-8` download links. (#8709)
  Bump external/Java.Interop from `07c7300` to `7f08b77` (#8702)
  Bump to xamarin/monodroid@848d1277b7 (#8691)
  [Xamarin.Android.Build.Tasks] `FixAbstractMethodsStep` performance (#8650)
  Bump to dotnet/installer@fb7b9a4b9e 9.0.100-preview.2.24106.6 (#8700)
  [Mono.Android] Cache `Profiles/api-34.xml` contents (#8679)
  [monodroid] typemaps may need to load assemblies (#8625)
  Bump $(AndroidNetPreviousVersion) to 34.0.79 (#8693)
  Bump to xamarin/java.interop/main@07c73009 (#8681)
  Bump to dotnet/installer@1c496970b7 9.0.100-preview.2.24078.1 (#8685)
  [GetAndroidDependencies] Add Jdk dependency info (#8651)
  [xaprepare] Add support for newer SparkyLinux (#8684)
  Bump to dotnet/installer@5680e93cb2 9.0.100-preview.2.24073.12 (#8666)
  $(AndroidPackVersionSuffix)=preview.2; net9 is 34.99.0.preview.2 (#8678)
  ...
@github-actions github-actions bot locked and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants