Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localized file check-in by OneLocBuild Task: Build definition ID 17928: Build ID 9462426 #8894

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

vs-mobiletools-engineering-service2
Copy link
Collaborator

This is the pull request automatically created by the OneLocBuild task in the build process to check-in localized files generated based upon translation source files (.lcl files) handed-back from the downstream localization pipeline. If there are issues in translations, visit https://aka.ms/icxLocBug and log bugs for fixes. The OneLocBuild wiki is https://aka.ms/onelocbuild and the localization process in general is documented at https://aka.ms/AllAboutLoc.

@dellis1972
Copy link
Contributor

Err this is translating all the files back to english?

@jonathanpeppers
Copy link
Member

@pjcollins do you know if we'd have to merge this before the new translations come in? Maybe we merge for main, and eventually new translations come in?

Reading what changed, 7938f14, the old translations seem like they are better than going back to English.

@pjcollins
Copy link
Member

@pjcollins do you know if we'd have to merge this before the new translations come in? Maybe we merge for main, and eventually new translations come in?

Reading what changed, 7938f14, the old translations seem like they are better than going back to English.

Looking again at the diagram and docs here new strings or changed strings result in english stubs being generated that can be handed off for translation. By my understanding we do need to merge this so that new translations can start to be created and contributed back.

Looking at a previous workflow for a new string (which should also apply to updated strings):

  1. New error code/string added in [Xamarin.Android.Build.Tasks] error for Android.Support #8629
  2. Initial English stubs for the new string added the next day in Localized file check-in by OneLocBuild Task: Build definition ID 17928: Build ID 8944839 #8652 after the nightly loc job ran.
  3. First update with translations a few days later in Localized file check-in by OneLocBuild Task: Build definition ID 17928: Build ID 8952275 #8657
  4. Localization finished within a week in Localized file check-in by OneLocBuild Task: Build definition ID 17928: Build ID 8968258 #8668

We should merge this as is and expect localized string updates to start to flow in within a few days. However, we probably should wait to merge until after .NET 9 Preview 4 branches as we likely don't want to release these english stubs.

@jonathanpeppers
Copy link
Member

I'll merge this one right after we get:

@jonathanpeppers jonathanpeppers merged commit 460b187 into main Apr 23, 2024
46 of 48 checks passed
@jonathanpeppers jonathanpeppers deleted the locpr/717c8d6f-ae41-470e-acce-42f7a59c2137 branch April 23, 2024 18:52
grendello added a commit that referenced this pull request Apr 24, 2024
* main:
  [docs] Reorganize public Documentation (#8889)
  Bump external/Java.Interop from `06214ff` to `6cfa78c` (#8879)
  Localized file check-in by OneLocBuild Task (#8894)
  $(AndroidPackVersionSuffix)=preview.5; net9 is 34.99.0.preview.5 (#8896)
grendello added a commit that referenced this pull request Apr 25, 2024
* main: (26 commits)
  [Mono.Android] fix potential leak of RunnableImplementors (#8900)
  [build] Bump $(AndroidNetPreviousVersion) to 34.0.95 (#8898)
  [docs] Reorganize public Documentation (#8889)
  Bump external/Java.Interop from `06214ff` to `6cfa78c` (#8879)
  Localized file check-in by OneLocBuild Task (#8894)
  $(AndroidPackVersionSuffix)=preview.5; net9 is 34.99.0.preview.5 (#8896)
  Bump to xamarin/monodroid@a5742221b3 (#8893)
  Remove MonoArchive_BaseUri from Configurables.cs (#8890)
  Bump to xamarin/xamarin-android-binutils/L_18.1.4-8.0.0@758d2e7 (#8885)
  [Mono.Android] Bind API-VanillaIceCream Beta 1 (#8891)
  [AndroidToolTask] Log tool output as error  (#8861)
  [Xamarin.Android.Build.Tasks] Remove "Xamarin" from messages (#8884)
  [Mono.Android] Bind API-VanillaIceCream Developer Preview 2 (#8741)
  Bump to dotnet/installer@22ffa42d6c 9.0.100-preview.4.24221.5 (#8887)
  Bump external/xamarin-android-tools from `37d79c9` to `05f9a90` (#8869)
  Bump external/Java.Interop from `e1c7832` to `06214ff` (#8878)
  Bump to dotnet/installer@7380c301c1 9.0.100-preview.4.24215.2 (#8874)
  [Mono.Android] Commit baseline PublicAPI files for API-35 (#8840)
  Add a unit test to check environment processing (#8856)
  Don't use azureedge.net CDN (#8846)
  ...
jonathanpeppers pushed a commit that referenced this pull request Apr 29, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants