[Xamarin.Android.Build.Tasks] remove $(_InstantRunEnabled) checks
#9292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: xamarin/monodroid@93ab95e Context: xamarin/monodroid@2c64cd5 "Enhanced Fast Deployment" was removed from our private sources, so we can now remove the following from our MSBuild logic: * `$(_InstantRunEnabled)` checks from MSBuild targets, it is `false` * `InstantRunEnabled` parameters in any MSBuild tasks or related classes * Usage of the `@(_InstantRunJavaReference)` item group For one parameter of `<GenerateJavaStubs/>`, I created a private property `$(_AndroidGenerateNativeAssembly)` that defaults to `true`. In a future PR, we could consider making runtime changes to remove `instant_run_enabled` as well.
jonathanpeppers
requested review from
mcumming,
jonpryor,
grendello and
dellis1972
as code owners
grendello
approved these changes
Sep 11, 2024
|
Once this PR is merged I'll open another one to update the native runtime accordingly. |
dellis1972
approved these changes
Sep 11, 2024
grendello
added a commit
that referenced
this pull request
Sep 11, 2024
Context: #9292 With "Enhanced Fast Deployment" no longer part of .NET for Android, remove the native runtime side of its support.
|
Native runtime PR: #9297 |
dellis1972
pushed a commit
that referenced
this pull request
Sep 11, 2024
Context: #9292 With "Enhanced Fast Deployment" no longer part of .NET for Android, remove the native runtime side of its support.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://github.com/xamarin/monodroid/commit/93ab95e18077d56d9d55ce7b4069a534e2dea35e
Context: https://github.com/xamarin/monodroid/commit/2c64cd5f533616ff4751fb1df6bbfc7e170477ae
"Enhanced Fast Deployment" was removed from our private sources, so we can now remove the following from our MSBuild logic:
$(_InstantRunEnabled)checks from MSBuild targets, it isfalseInstantRunEnabledparameters in any MSBuild tasks or related classesUsage of the
@(_InstantRunJavaReference)item groupFor one parameter of
<GenerateJavaStubs/>, I created a private property$(_AndroidGenerateNativeAssembly)that defaults totrue.In a future PR, we could consider making runtime changes to remove
instant_run_enabledas well.