[build] Fix make prepare ordering
#937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Clancey was trying to build xamarin-android, which failed: $ make prepare ./build-tools/scripts/generate-os-info Configuration.OperatingSystem.props xbuild /p:Configuration=Debug /p:_DebugFileExt=.pdb build-tools/dependencies/dependencies.mdproj ... warning : Referenced Project ../../external/xamarin-android-tools/src/Xamarin.Android.Tools.AndroidSdk/Xamarin.Android.Tools.AndroidSdk.csproj not found, ignoring. ... Xamarin.Android.BuildTools.PrepTasks/JdkInfo.cs(9,23): error CS0234: The type or namespace name 'Tools' does not exist in the namespace 'Xamarin.Android' (are you missing an assembly reference?) The problem is that `make prepare-deps`, which builds `build-tools/dependencies/dependencies.mdproj`, implicitly builds `build-tools/xa-prep-tasks/xa-prep-tasks.csproj`, which in turn depends on `external/xamarin-android-tools/src/Xamarin.Android.Tools.AndroidSdk/Xamarin.Android.Tools.AndroidSdk.csproj`, which is only reliably created by `make prepare-external`s `git submodule update --init --recursive`. Unfortunately, `make prepare-external` wasn't invoked until *after* `make prepare-deps`, meaning there is no way for `make prepare` to actually work on a clean install! (This works on Jenkins because Jenkins automatically checks out all submodules, so it never encounters this "clean checkout" scenario.) Reorder the targets that `make prepare` executes so that `make prepare-external` is run *before* `make prepare-deps`, ensuring that git submodules exist before we attempt to use them.
Redth
pushed a commit
to Redth/xamarin-android
that referenced
this pull request
Oct 30, 2017
@Clancey was trying to build xamarin-android, which failed: $ make prepare ./build-tools/scripts/generate-os-info Configuration.OperatingSystem.props xbuild /p:Configuration=Debug /p:_DebugFileExt=.pdb build-tools/dependencies/dependencies.mdproj ... warning : Referenced Project ../../external/xamarin-android-tools/src/Xamarin.Android.Tools.AndroidSdk/Xamarin.Android.Tools.AndroidSdk.csproj not found, ignoring. ... Xamarin.Android.BuildTools.PrepTasks/JdkInfo.cs(9,23): error CS0234: The type or namespace name 'Tools' does not exist in the namespace 'Xamarin.Android' (are you missing an assembly reference?) The problem is that `make prepare-deps`, which builds `build-tools/dependencies/dependencies.mdproj`, implicitly builds `build-tools/xa-prep-tasks/xa-prep-tasks.csproj`, which in turn depends on `external/xamarin-android-tools/src/Xamarin.Android.Tools.AndroidSdk/Xamarin.Android.Tools.AndroidSdk.csproj`, which is only reliably created by `make prepare-external`s `git submodule update --init --recursive`. Unfortunately, `make prepare-external` wasn't invoked until *after* `make prepare-deps`, meaning there is no way for `make prepare` to actually work on a clean install! (This works on Jenkins because Jenkins automatically checks out all submodules, so it never encounters this "clean checkout" scenario.) Reorder the targets that `make prepare` executes so that `make prepare-external` is run *before* `make prepare-deps`, ensuring that git submodules exist before we attempt to use them.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Clancey was trying to build xamarin-android, which failed:
The problem is that
make prepare-deps, which buildsbuild-tools/dependencies/dependencies.mdproj, implicitly buildsbuild-tools/xa-prep-tasks/xa-prep-tasks.csproj, which in turndepends on
external/xamarin-android-tools/src/Xamarin.Android.Tools.AndroidSdk/Xamarin.Android.Tools.AndroidSdk.csproj,which is only reliably created by
make prepare-externalsgit submodule update --init --recursive.Unfortunately,
make prepare-externalwasn't invoked until aftermake prepare-deps, meaning there is no way formake preparetoactually work on a clean install!
(This works on Jenkins because Jenkins automatically checks out all
submodules, so it never encounters this "clean checkout" scenario.)
Reorder the targets that
make prepareexecutes so thatmake prepare-externalis run beforemake prepare-deps, ensuringthat git submodules exist before we attempt to use them.