[Xamarin.Android.Build.Tasks] Updates for xabuild.exe #940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -21,6 +21,10 @@ public static bool Create (string source, string target) | |||
| } | |||
| } else { | |||
| try { | |||
| var sourceInfo = new UnixFileInfo (source); | |||
There was a problem hiding this comment.
It's odd, it sounds like this Directory.Exists check isn't working. Is there a test/app I can try to see this breaking?
Is there a way to do this where the symbolic link is recreated on Windows, too? Is delete directory/recreate the link the only way to do that?
There was a problem hiding this comment.
I have no idea how this would work on windows.
I hit this by running the msbuild unit tests using MSBUILD=msbuild.
so just using MSBUILD=msbuild xabuild should repo the problem.
dellis1972
commented
Oct 17, 2017
| return Path.GetFullPath (Path.Combine (Root, "..", "..", "tools", "scripts", "xabuild")); | ||
| var xaBuildPath = Path.GetFullPath (Path.Combine (Root, "..", "..", "tools", "scripts", "xabuild")); | ||
| if (!File.Exists (xaBuildPath)) | ||
| xaBuildPath = Path.GetFullPath (Path.Combine (Root, "..", "..", "..", "..", "..", "..", "..", "tools", "scripts", "dbuild")); |
There was a problem hiding this comment.
This should fix the unit tests in monodroid.
tools/xabuild/SymbolicLink.cs
Outdated
| return true; | ||
| } | ||
| Console.Error.WriteLine ($"Unable to create symbolic link from `{source}` to `{target}`: {exc}"); | ||
| return Directory.Exists (source); |
There was a problem hiding this comment.
I think if we add the same return Directory.Exists (source) for Windows, we're good.
I tested what happens on Windows if you try to create a symlink (and it already exists). It gives a generic error message The system cannot find the file specified, so we don't have a way to check for the specific error condition.
dellis1972
force-pushed
the
xabuildexe
branch
from
a4e87c7 to
94cffa2
Compare
This commit fixes a couple of issues which appeared when using xabuild.exe on macos. Firstly if the symlink exists already the SymbolicLink code will error out and fail the build completely. This happens because if you run two or more xabuild.exe instances at the same time they trip over each other trying to create the symlink. So rather than erroring completely we should only error if the link does NOT exist. If it does exist after an attempted creation we should ignore the exception. The other is about where we look for extensions. Xamarin.Android is installed on mac into /Library/Frameworks/Mono.framework/External/xbuild this was not included in the search path for MSbuild, so it never manages to find the required .targets.
dellis1972
force-pushed
the
xabuildexe
branch
from
94cffa2 to
af4e4bf
Compare
jonathanpeppers
approved these changes
Oct 17, 2017
Redth
pushed a commit
to Redth/xamarin-android
that referenced
this pull request
Oct 30, 2017
This commit fixes a couple of issues which appeared when using `xabuild.exe` on macOS. Firstly if the symlink exists already the SymbolicLink code will error out and fail the build completely. This happens because if you run two or more `xabuild.exe` instances at the same time they trip over each other trying to create the symlink. So rather than error'ing completely we should only error if the link does NOT exist. If it does exist after an attempted creation we should ignore the exception. The other is about where we look for extensions. Xamarin.Android is installed on macOS into /Library/Frameworks/Mono.framework/External/xbuild this was not included in the search path for MSBuild, so it never manages to find the required `.targets` files.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a couple of issues which appeared when
using xabuild.exe on macos. Firstly if the symlink exists
already the SymbolicLink code will error out and fail the
build completely. This happens because if you run two or
more xabuild.exe instances at the same time they trip over
each other trying to create the symlink.
So rather than erroring completely we should only error if
the link does NOT exist. If it does exist after an attempted
creation we should ignore the exception.
The other is about where we look for extensions. Xamarin.Android
is installed on mac into
this was not included in the search path for MSbuild, so it never
manages to find the required .targets.