-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests] use x86_64 API 23 image on nightly pipeline #9414
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Context: dotnet/runtime#106025 Context: https://discord.com/channels/732297728826277939/732297837953679412/1296764055654240317 `Mono.Android-Tests` on API 23 crash on launch with: 09-17 14:41:32.839 2758 2758 I monodroid-assembly: Failed to load shared library '/data/app/Mono.Android.NET_Tests-1/split_config.x86.apk!/lib/x86/libSystem.Native.so'. dlopen failed: cannot find "libc.so" from verneed[1] in DT_NEEDED list for "/data/app/Mono.Android.NET_Tests-1/split_config.x86.apk" But this same library appears to be correct, and loads on all of: * x86 API 21 * x86_64 API 23 * x86 API 24 This leads us to believe there is some kind of bug with loading native libraries on the API 23 x86 emulator image. For now, let's just target x86_64 on API 23 for the time being.
jonathanpeppers
force-pushed
the
dev/peppers/sdkmanager/update
branch
from
October 18, 2024 14:13
0d95633
to
2a2b47c
Compare
jonathanpeppers
changed the title
[tests] run
[tests] use x86_64 API 23 image on nightly pipeline
Oct 18, 2024
sdkmanager update
before installing emulators
grendello
approved these changes
Oct 18, 2024
pjcollins
approved these changes
Oct 18, 2024
avdApiLevel: 23 | ||
avdAbi: x86 | ||
avdAbi: x86_64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of the goals of the nightly job was to increase our API/ABI coverage to catch potential issues like this. It seems possible that we have a regression here somewhere, but given that the potential impact is likely quite low I think this is reasonable.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: dotnet/runtime#106025
Context: https://discord.com/channels/732297728826277939/732297837953679412/1296764055654240317
Mono.Android-Tests
on API 23 crash on launch with:But this same library appears to be correct, and loads on all of:
This leads us to believe there is some kind of bug with loading native
libraries on the API 23 x86 emulator image.
For now, let's just target x86_64 on API 23 for the time being.