[Xamarin.Android.Build.Tasks] fix incremental builds for _GenerateAndroidRemapNativeCode
#9548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…droidRemapNativeCode`
I've noticed we are randomly seeing a test failure like:
Build_AndroidResource_Change
Exceeded expected time of 2250ms, actual 2992.086ms
Sometimes, it passes and sometimes not.
Reviewing the `.binlog` I noticed under the top 10 expensive tasks:
GenerateJniRemappingNativeCode = 97 ms, 1 calls.
Which I found by the target:
_GenerateEmptyAndroidRemapNativeCode
Building target "_GenerateEmptyAndroidRemapNativeCode" completely.
Input file "/Users/runner/work/1/a/TestRelease/11-21_21.07.33/temp/BuildAndroidResourceChange/UnnamedProject.csproj" is newer than output file "obj/Debug/android/jni_remap.x86_64.ll".
Which has the `Inputs/Outputs`:
Inputs="$(MSBuildProjectFullPath)"
Outputs="@(_AndroidRemapAssemblySource)"
Reviewing the target, it feels like we should fix the `Inputs` and
`Outputs`, such as:
* `Inputs` should include all MSBuild files
`@(_AndroidMSBuildAllProjects)`, as settings could be in
`Directory.Build.props`, etc.
* `Inputs` should include `build.props` if that file changes to force
a rerun.
* We should `<Touch/>` the `Outputs` files to prevent the target from
running when it doesn't need to.
After these changes, I'm hoping `Build_AndroidResource_Change` passes
more reliably, we will see.
|
The APK test failures are networking, we can ignore those: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed we are randomly seeing a test failure like:
Sometimes, it passes and sometimes not.
Reviewing the
.binlogI noticed under the top 10 expensive tasks:Which I found by the target:
Which has the
Inputs/Outputs:Reviewing the target, it feels like we should fix the
InputsandOutputs, such as:Inputsshould include all MSBuild files@(_AndroidMSBuildAllProjects), as settings could be inDirectory.Build.props, etc.Inputsshould includebuild.propsif that file changes to force a rerun.We should
<Touch/>theOutputsfiles to prevent the target from running when it doesn't need to.After these changes, I'm hoping
Build_AndroidResource_Changepasses more reliably, we will see.