CLR hosting #9572

grendello · 2024-12-02T21:16:21Z

No description provided.

* Add a version script which hides all the symbols except for the handful we have to export. * Enable exceptions

In process to remove object instances for a slightly faster startup

Build is broken atm

jonathanpeppers · 2024-12-03T22:32:06Z

build-tools/create-packs/Microsoft.Android.Runtime.proj

-      <_AndroidRuntimePackAssets Include="$(MicrosoftAndroidSdkOutDir)lib\$(AndroidRID)\libmono-android.debug.so" />
-      <_AndroidRuntimePackAssets Include="$(MicrosoftAndroidSdkOutDir)lib\$(AndroidRID)\libmono-android.release.so" />
+      <_AndroidRuntimePackAssets Condition=" Exists('$(MicrosoftAndroidSdkOutDir)lib\$(AndroidRID)\libmono-android.debug.so') " Include="$(MicrosoftAndroidSdkOutDir)lib\$(AndroidRID)\libmono-android.debug.so" />
+      <_AndroidRuntimePackAssets Condition=" Exists('$(MicrosoftAndroidSdkOutDir)lib\$(AndroidRID)\libmono-android.release.so') " Include="$(MicrosoftAndroidSdkOutDir)lib\$(AndroidRID)\libmono-android.release.so" />
+      <_AndroidRuntimePackAssets Condition=" Exists('$(MicrosoftAndroidSdkOutDir)lib\$(AndroidRID)\libnet-android.debug.so') " Include="$(MicrosoftAndroidSdkOutDir)lib\$(AndroidRID)\libnet-android.debug.so" />
+      <_AndroidRuntimePackAssets Condition=" Exists('$(MicrosoftAndroidSdkOutDir)lib\$(AndroidRID)\libnet-android.release.so') " Include="$(MicrosoftAndroidSdkOutDir)lib\$(AndroidRID)\libnet-android.release.so" />


I'm fixing this up in #9583, but maybe I can split up part of it into a smaller PR.

* Add a version script which hides all the symbols except for the handful we have to export. * Enable exceptions

* main: [illink] consolidate & remove hardcoded assembly names (#9662) Bump to NuGet/NuGet.Client@aa7eb998 (#9682) [Microsoft.Android.Sdk.Analysis] fix global types (#9680)

jonathanpeppers · 2025-01-15T15:58:08Z

Configuration.props

@@ -216,5 +218,6 @@
  <ItemGroup>
    <AndroidAbiAndRuntimeFlavor Include="@(AndroidSupportedTargetJitAbi)" AndroidRuntime="Mono" />
    <AndroidAbiAndRuntimeFlavor Include="@(AndroidSupportedTargetJitAbi)" AndroidRuntime="NativeAOT" />
+    <AndroidAbiAndRuntimeFlavor Include="@(AndroidSupportedTargetJitAbi)" AndroidRuntime="CoreCLR" />


I couldn't figure out if we should case it CoreClr or CoreCLR:

https://grep.app/search?q=CoreCLR&case=true&filter[repo][0]=dotnet/runtime

https://grep.app/search?q=CoreClr&case=true&filter[repo][0]=dotnet/runtime

I found both, so we can probably decide which we prefer?

I like CoreCLR better, since CLR is an acronym

jonathanpeppers · 2025-01-15T16:01:39Z

...d.Build.Tasks/Microsoft.Android.Sdk/targets/Microsoft.Android.Sdk.AssemblyResolution.targets

+      <_ExcludedNativeLibraries Condition=" '$(AndroidRuntime)' == 'Mono' Or '$(AndroidRuntime)' == '' " Include="libnet-android.debug" />
+      <_ExcludedNativeLibraries Condition=" '$(AndroidRuntime)' == 'Mono' Or '$(AndroidRuntime)' == '' " Include="libnet-android.release" />
+      <_ExcludedNativeLibraries Condition=" '$(AndroidRuntime)' == 'CoreCLR' " Include="libmono-android.debug" />
+      <_ExcludedNativeLibraries Condition=" '$(AndroidRuntime)' == 'CoreCLR' " Include="libmono-android.release" />


So, $(AndroidRuntime) isn't defined for customer's project builds. I think it would always be blank?

Right now, we only have these:

$(UseMonoRuntime)=true

$(_AndroidNativeAot)=true

Maybe we need to figure out what property xamarin/xamarin-macios uses to identify CoreCLR? You can use it for macOS, to choose between Mono & CoreCLR.

Yeah, it would always be blank now and I think we should always expect a value in there. The macios way looks fine.

jonathanpeppers · 2025-01-15T16:06:58Z

src/Xamarin.Android.Build.Tasks/Xamarin.Android.Common.targets

+  <_AndroidUseCLR Condition=" '$(AndroidRuntime)' == 'CoreCLR' ">True</_AndroidUseCLR>
+  <_AndroidUseCLR Condition=" '$(AndroidRuntime)' != 'CoreCLR' ">False</_AndroidUseCLR>


$(AndroidRuntime) is probably always blank in customer's Android projects, but is this the property to select a runtime? Should the property be in DefaultProperties.targets?

Maybe we should align with xamarin/xamarin-macios?

jonathanpeppers · 2025-01-15T16:42:34Z

Ok, here is what we should do for MSBuild properties for now:

$(_AndroidRuntime) is the property we use throughout Android project builds (customer projects), it can say MonoVM, NativeAOT, or CoreCLR. It is a private property.
If PublishAot=true, $(_AndroidRuntime)=NativeAOT
If UseMonoRuntime=false, $(_AndroidRuntime)=CoreCLR
If $(UseMonoRuntime)="", we default to $(UseMonoRuntime)=true in DefaultProperties.targets
If UseMonoRuntime=true, $(_AndroidRuntime)=MonoVM

We could remove $(_AndroidNativeAot) and check '$(_AndroidRuntime)' == 'NativeAOT' instead. If we keep it, we should introduce $(_AndroidCoreClr).

grendello · 2025-01-15T17:00:39Z

Ok, here is what we should do for MSBuild properties for now:
* `$(_AndroidRuntime)` is the property we use throughout Android project builds (customer projects), it can say `MonoVM`, `NativeAOT`, or `CoreCLR`. It is a private property.

* If `PublishAot=true`, `$(_AndroidRuntime)=NativeAOT`

* If `UseMonoRuntime=false`, `$(_AndroidRuntime)=CoreCLR`

* If `$(UseMonoRuntime)=""`, we default to `$(UseMonoRuntime)=true` in `DefaultProperties.targets`

* If `UseMonoRuntime=true`, `$(_AndroidRuntime)=MonoVM`
We could remove $(_AndroidNativeAot) and check '$(_AndroidRuntime)' == 'NativeAOT' instead. If we keep it, we should introduce $(_AndroidCoreClr).

I like $(_AndroidRuntime) for this, it's much leaner and reads better IMO :)

Context: #9572 (comment) Context: https://github.com/xamarin/xamarin-macios/blob/2009c571aa8a975ab0e0b1785e5484dbd64d6f9b/dotnet/targets/Xamarin.Shared.Sdk.targets#L1004-L1006 To align with xamarin/xamarin-macios, the following public MSBuild properties can be used to select a runtime for iOS, macOS, etc.: * `$(UseMonoRuntime)=true`: MonoVM * `$(UseMonoRuntime)=false`: CoreCLR * `$(PublishAot)=true`: NativeAOT * Defaults if blank, select MonoVM Introduce a private `$(_AndroidRuntime)` property we can use throughout our build to know which runtime is being targetted. This way, if a new property is designed in the future, we can keep using `$(_AndroidRuntime)` and simply update the defaults.

* main: [ci] Run Mac MSBuild tests on `macos-14-arm64` (#9665)

* main: [Mono.Android-Tests] Ignore "BadGateway" test failures. (#9687) [build] Build with Microsoft OpenJDK 21.0.5 (#9683)

…ad of the linux-bionic one

* main: [Mono.Android] Java.Interop Unification! (#9640)

…#9686) Context: #9572 (comment) Context: https://github.com/xamarin/xamarin-macios/blob/2009c571aa8a975ab0e0b1785e5484dbd64d6f9b/dotnet/targets/Xamarin.Shared.Sdk.targets#L1004-L1006 To align with xamarin/xamarin-macios, the following public MSBuild properties can be used to select a runtime for iOS, macOS, etc.: * `$(UseMonoRuntime)=true`: MonoVM * `$(UseMonoRuntime)=false`: CoreCLR * `$(PublishAot)=true`: NativeAOT * Defaults if blank, select MonoVM Introduce a private `$(_AndroidRuntime)` property we can use throughout our build to know which runtime is being targeted. This way, if a new property is designed in the future, we can keep using `$(_AndroidRuntime)` and simply update the defaults.

Some of those changes will stay, most will go. Makes it possible to move foreward for now without having CoreCLR packs for all the targets. Only arm64 supported atm

* main: [Xamarin.Android.Build.Tasks] introduce `$(_AndroidRuntime)` property (#9686)

This time to include the actual CoreCLR Android runtime in the apk

* main: Bump to dotnet/java-interop@9b1d878 (#9694) Bump to dotnet/sdk@aca4b810e2 10.0.100-alpha.1.25069.2 (#9696)

grendello force-pushed the dev/grendel/clr-host branch from cbc08f4 to 0370d7d Compare December 3, 2024 12:41

grendello added 24 commits December 3, 2024 15:11

Enable static linking with libc++

4c6b83d

* Add a version script which hides all the symbols except for the handful we have to export. * Enable exceptions

Remove C++ ABI compatibility sources

e2f89a4

Update apkdesc files

e2ad767

Playing around with some ideas

33500bb

More consistent use of std::string_view + remove unused code

95ecd76

Making EmbeddedAssemblies a static type

539b080

In process to remove object instances for a slightly faster startup

More cleanup

2aa6e2b

More move to static, more cleanup

07246e5

MonodroidRuntime is static now

6649f01

Buglets fixed

51e007a

Trying to find out why AppContext.GetData doesn't appear to work

497e094

Cleanup

00d300f

Lengths and offsets...

69a35ad

Cleanup

01c77c0

Start using std::format and std::string_view string literals

e0b1e57

A bit less of reinterpret_cast<>

15ace79

Conversion to std::format continues

28c6439

Build is broken atm

More std::format

98a4054

Friendlier, no need to use std::format directly in log_* anymore

ac5c3ed

Cleanup

886ef40

Cleanup

15d864f

Update apkdesc files

00f55b5

std::format doesn't like null pointers when printing strings

d383a44

Address feedback

5a4d188

grendello force-pushed the dev/grendel/clr-host branch 2 times, most recently from c085352 to 13bbd93 Compare December 3, 2024 21:15

jonathanpeppers reviewed Dec 3, 2024

View reviewed changes

grendello force-pushed the dev/grendel/clr-host branch from 13bbd93 to 82cfb8a Compare December 4, 2024 18:47

Enable static linking with libc++

18fd987

* Add a version script which hides all the symbols except for the handful we have to export. * Enable exceptions

grendello added 6 commits January 14, 2025 20:48

Fix java runtime jar inclusion

8fa07fa

Recreate @(ResolvedRuntimePack) item group

b91865d

Merge branch 'main' into dev/grendel/clr-host

160c059

* main: [illink] consolidate & remove hardcoded assembly names (#9662) Bump to NuGet/NuGet.Client@aa7eb998 (#9682) [Microsoft.Android.Sdk.Analysis] fix global types (#9680)

Double-check if a nuget package is indeed our runtime pack

9f71a63

Don't package runtime stubs

8b3977b

Not needed

41d075e

jonathanpeppers reviewed Jan 15, 2025

View reviewed changes

jonathanpeppers mentioned this pull request Jan 15, 2025

[Xamarin.Android.Build.Tasks] introduce $(_AndroidRuntime) property #9686

Merged

grendello added 14 commits January 16, 2025 09:23

Merge branch 'main' into dev/grendel/clr-host

0438495

* main: [ci] Run Mac MSBuild tests on `macos-14-arm64` (#9665)

Update to match main

b857673

Remove unnecessary sources

394a016

Import changes from #9686

9ca6c05

Mono -> MonoVM

425301c

Fixes

2d4691f

Fixes and workarounds to make CoreCLR build happen

198acae

Merge branch 'main' into dev/grendel/clr-host

9eef4c4

* main: [Mono.Android-Tests] Ignore "BadGateway" test failures. (#9687) [build] Build with Microsoft OpenJDK 21.0.5 (#9683)

Hack to be able to use CoreCLR runtime pack we created

579505f

Fake CoreCLR runtime pack works. Next step: use correct CoreCLR inste…

66a32f5

…ad of the linux-bionic one

Merge branch 'main' into dev/grendel/clr-host

79a7006

* main: [Mono.Android] Java.Interop Unification! (#9640)

Add support for local version of CoreCLR runtime pack

cc64d57

Support for CoreCLR in xaprepare

9421f41

Limit CoreCLR builds to android-arm64 for now

487dac0

grendello added 4 commits January 21, 2025 19:05

Build tweaks to make progress easier

3803f37

Some of those changes will stay, most will go. Makes it possible to move foreward for now without having CoreCLR packs for all the targets. Only arm64 supported atm

Merge branch 'main' into dev/grendel/clr-host

0e0b648

* main: [Xamarin.Android.Build.Tasks] introduce `$(_AndroidRuntime)` property (#9686)

A couple more hacks

e47f577

This time to include the actual CoreCLR Android runtime in the apk

Merge branch 'main' into dev/grendel/clr-host

f027b24

* main: Bump to dotnet/java-interop@9b1d878 (#9694) Bump to dotnet/sdk@aca4b810e2 10.0.100-alpha.1.25069.2 (#9696)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CLR hosting #9572

CLR hosting #9572

grendello commented Dec 2, 2024 •

edited

Loading

jonathanpeppers Dec 3, 2024

jonathanpeppers Jan 15, 2025

grendello Jan 15, 2025

jonathanpeppers Jan 15, 2025

grendello Jan 15, 2025

jonathanpeppers Jan 15, 2025

jonathanpeppers commented Jan 15, 2025

grendello commented Jan 15, 2025

		<_AndroidUseCLR Condition=" '$(AndroidRuntime)' == 'CoreCLR' ">True</_AndroidUseCLR>
		<_AndroidUseCLR Condition=" '$(AndroidRuntime)' != 'CoreCLR' ">False</_AndroidUseCLR>

CLR hosting #9572

Are you sure you want to change the base?

CLR hosting #9572

Conversation

grendello commented Dec 2, 2024 • edited Loading

jonathanpeppers Dec 3, 2024

Choose a reason for hiding this comment

jonathanpeppers Jan 15, 2025

Choose a reason for hiding this comment

grendello Jan 15, 2025

Choose a reason for hiding this comment

jonathanpeppers Jan 15, 2025

Choose a reason for hiding this comment

grendello Jan 15, 2025

Choose a reason for hiding this comment

jonathanpeppers Jan 15, 2025

Choose a reason for hiding this comment

jonathanpeppers commented Jan 15, 2025

grendello commented Jan 15, 2025

grendello commented Dec 2, 2024 •

edited

Loading