-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mono.Android] Bind Android API-36 DP1. #9594
Conversation
a2983d2
to
5bb113c
Compare
Commit e4a75a8 removed some make magic that ensured Mono.Android.dll would be built multiple times for additional supported API levels. A couple of MSBuild tasks used to build multiple versions of Mono.Android.dll have been moved out of the `PackDotNet` target used by the Windows build and into the Mono.Android build to fix this. (cherry picked from commit c1d3e8e)
/> | ||
<MSBuild | ||
Condition=" '$(AndroidLatestUnstableApiLevel)' != '$(AndroidLatestStableApiLevel)' " | ||
Projects="$(_Root)src\Mono.Android\Mono.Android.csproj" | ||
Properties="TargetFramework=$(DotNetTargetFramework);AndroidApiLevel=$(AndroidLatestUnstableApiLevel);AndroidPlatformId=$(AndroidLatestUnstablePlatformId);DisableApiCompatibilityCheck=true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add these DisableApiCompatibilityCheck=true properties back when building on Windows if necessary, but wanted to test again without them first
@jpobst I think this is building correctly now, but there may be some ApiCompat things to look at |
@pjcollins Fixed the ApiCompat thing, now it's back on a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me. 👍
<!-- Rename Namespaces --> | ||
<attr api-since="36" path="/api/package[@name='android.app.appfunctions']" name="managedName">Android.App.AppFunctions</attr> | ||
<attr api-since="36" path="/api/package[@name='android.app.appsearch.functions']" name="managedName">Android.App.AppSearch.Functions</attr> | ||
<attr api-since="36" path="/api/package[@name='android.configinfrastructure.aconfig']" name="managedName">Android.ConfigInfrastructure.Aconfig</attr> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if we have a past example, but if aconfig
is short for "Android Config", should the C# namespace be Android.ConfigInfrastructure.AConfig
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I researched this one to see what Google's intent is. I generally defer to the way they have named their types which in this case is indeed Aconfig
:
https://developer.android.com/reference/android/configinfrastructure/aconfig/AconfigPackage?hl=en
@jpobst: should this also update Lines 32 to 34 in 894ecea
This would make it "reasonable" for me to add |
Context: https://developer.android.com/about/versions/16
Context: https://android-developers.googleblog.com/2024/11/the-first-developer-preview-android16.html
Android 16 Developer Preview 1 has been released. The Android 16
Developer Preview Program Overview Timeline and updates section
suggests the following timeline:
Currently, this will be usable in its preview form to
main
users who explicitly targetnet9.0-android36
. Once we are shipping .NET 10 previews, it will be usable for users who explicitly targetnet10.0-android36
. We will need to decide on our strategy for backporting this to .NET 9 service releases.PublicApiAnalyzers
reports 2 categories of API changes (PublicAPI.Shipped.txt
):?
->!
)