Log work item start/end/exception using current's scope logger (#4299)

dotnet · Jan 6, 2025 · ec58592 · ec58592
1 parent 76baee7
commit ec58592
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/src/ProductConstructionService/ProductConstructionService.WorkItems/WorkItemScope.cs b/src/ProductConstructionService/ProductConstructionService.WorkItems/WorkItemScope.cs
@@ -64,10 +64,20 @@ async Task ProcessWorkItemAsync()
             using (var operation = telemetryClient.StartOperation<RequestTelemetry>(type))
             using (logger.BeginScope(processor.GetLoggingContextData(workItem)))
             {
-                var success = await processor.ProcessWorkItemAsync(workItem, cancellationToken);
-                if (success)
+                try
                 {
-                    telemetryScope.SetSuccess();
+                    logger.LogInformation("Processing work item {type}", type);
+                    var success = await processor.ProcessWorkItemAsync(workItem, cancellationToken);
+                    if (success)
+                    {
+                        telemetryScope.SetSuccess();
+                    }
+                }
+                catch (Exception e)
+                {
+                    operation.Telemetry.Success = false;
+                    logger.LogError(e, "Failed to process work item {type}", type);
+                    throw;
                 }
             }
         }

diff --git a/src/ProductConstructionService/ProductConstructionService.WorkItems/WorkItemScopeManager.cs b/src/ProductConstructionService/ProductConstructionService.WorkItems/WorkItemScopeManager.cs
@@ -1,6 +1,7 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
+using Microsoft.ApplicationInsights;
 using Microsoft.DotNet.DarcLib;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Options;